Actions
action #116380
openSanitize code that leads to hickups in autoinst-log.txt
Status:
New
Priority:
Low
Assignee:
-
Target version:
-
Start date:
2022-09-08
Due date:
% Done:
0%
Estimated time:
Description
Observation¶
While analyzing problems with disabling nvidia repo I noticed some strange hickups in the autoinst-log.txt.
Odd number of elements in anonymous hash at /var/lib/openqa/pool/5/os-autoinst-distri-opensuse/tests/autoyast/installation.pm line 294.
installation::run(installation=HASH(0x55fdae8b3f68)) called at /usr/lib/os-autoinst/basetest.pm line 328
eval {...} called at /usr/lib/os-autoinst/basetest.pm line 322
basetest::runtest(installation=HASH(0x55fdae8b3f68)) called at /usr/lib/os-autoinst/autotest.pm line 367
eval {...} called at /usr/lib/os-autoinst/autotest.pm line 367
autotest::runalltests() called at /usr/lib/os-autoinst/autotest.pm line 243
eval {...} called at /usr/lib/os-autoinst/autotest.pm line 243
autotest::run_all() called at /usr/lib/os-autoinst/autotest.pm line 294
autotest::__ANON__(Mojo::IOLoop::ReadWriteProcess=HASH(0x55fdb0234968)) called at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/IOLoop/ReadWriteProcess.pm line 326
eval {...} called at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/IOLoop/ReadWriteProcess.pm line 326
Mojo::IOLoop::ReadWriteProcess::_fork(Mojo::IOLoop::ReadWriteProcess=HASH(0x55fdb0234968), CODE(0x55fdae8b4148)) called at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/IOLoop/ReadWriteProcess.pm line 488
Mojo::IOLoop::ReadWriteProcess::start(Mojo::IOLoop::ReadWriteProcess=HASH(0x55fdb0234968)) called at /usr/lib/os-autoinst/autotest.pm line 296
autotest::start_process() called at /usr/bin/isotovideo line 273
The code line that causes this looks like this:
wait_still_screen { send_key 'alt-o' };
This is the only usage of wait_still_screen with a hash and a send_key inside that in the whole os-autoinst-distri-opensuse repo.
Next example:
Odd number of elements in hash assignment at /var/lib/openqa/pool/5/os-autoinst-distri-opensuse/lib/utils.pm line 549.
utils::zypper_call("in autoyast2", 300) called at /var/lib/openqa/pool/5/os-autoinst-distri-opensuse/tests/autoyast/clone.pm line 21
clone::run(clone=HASH(0x55fdaead71a0)) called at /usr/lib/os-autoinst/basetest.pm line 328
eval {...} called at /usr/lib/os-autoinst/basetest.pm line 322
basetest::runtest(clone=HASH(0x55fdaead71a0)) called at /usr/lib/os-autoinst/autotest.pm line 367
eval {...} called at /usr/lib/os-autoinst/autotest.pm line 367
autotest::runalltests() called at /usr/lib/os-autoinst/autotest.pm line 243
eval {...} called at /usr/lib/os-autoinst/autotest.pm line 243
autotest::run_all() called at /usr/lib/os-autoinst/autotest.pm line 294
autotest::__ANON__(Mojo::IOLoop::ReadWriteProcess=HASH(0x55fdb0234968)) called at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/IOLoop/ReadWriteProcess.pm line 326
eval {...} called at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/IOLoop/ReadWriteProcess.pm line 326
Mojo::IOLoop::ReadWriteProcess::_fork(Mojo::IOLoop::ReadWriteProcess=HASH(0x55fdb0234968), CODE(0x55fdae8b4148)) called at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/IOLoop/ReadWriteProcess.pm line 488
Mojo::IOLoop::ReadWriteProcess::start(Mojo::IOLoop::ReadWriteProcess=HASH(0x55fdb0234968)) called at /usr/lib/os-autoinst/autotest.pm line 296
autotest::start_process() called at /usr/bin/isotovideo line 273
This time we have a strange usage of zypper_call:
zypper_call('in autoyast2', 300);
Probably the 300 should be the timeout, but nobody knows.
Scope:¶
At the moment its all autoyast stuff, but I would suggest, that whoever does a verification run not only looks if the result is "green" but also checks the autoinst-log.txt for such oddities.
Acceptance criteria:¶
AC1: Code flaws are corrected and hickups don't occur any longer.
Actions