Project

General

Profile

Actions
Copy link

action #115466

closed

Fix synchronization issue in grub_test for migration with AutoYaST from SLE-12-SP5

Added by tinawang123 over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
leli
Target version:
Current
Start date:
2022-08-18
Due date:
% Done:

0%

Estimated time:

Description

Motivation

Failed case: https://openqa.suse.de/tests/9353685#step/grub_test/2
Successful case: https://openqa.suse.de/tests/8753498#step/grub_test/3

Acceptance criteria

AC1: Fix synchronization issue taking into account that this module is heavily used.
AC2: File a bug if any

Suggestions

Consider what is special in this scenario and if makes more sense to create a additional module for this behavior.
Perhaps we need to touch code in 'lib/grub_utils.pm' file.
Seems that there is a different sequence of needles, this one doesn't follow exactly like in the successful one:
https://openqa.suse.de/tests/9353685#step/grub_test/2

Actions
Copy link
 #1

Updated by JERiveraMoya over 1 year ago

  • Description updated (diff)
  • Target version set to Current
Actions
Copy link
 #2

Updated by JERiveraMoya over 1 year ago

  • Subject changed from test fails in grub_test - it should not check ' inst-bootmenu-boot-harddisk ' needle, just wait system boot to Fix synchronization issue for migration with AutoYaST from SLE-12-SP5
  • Description updated (diff)
Actions
Copy link
 #3

Updated by JERiveraMoya over 1 year ago

  • Subject changed from Fix synchronization issue for migration with AutoYaST from SLE-12-SP5 to Fix synchronization issue in grub_test for migration with AutoYaST from SLE-12-SP5
  • Description updated (diff)
Actions
Copy link
 #4

Updated by JERiveraMoya over 1 year ago

  • Tags deleted (qe-yast-refinement)
  • Status changed from New to Workable
Actions
Copy link
 #5

Updated by leli over 1 year ago

  • Status changed from Workable to In Progress
  • Assignee set to leli
Actions
Copy link
 #6

Updated by leli over 1 year ago

'-' if (check_var("BOOTFROM", "d") && check_var("AUTOUPGRADE") && check_var("PATCH")) {
'+' if (check_var("BOOTFROM", "d") && get_var('AUTOUPGRADE') && get_var('PATCH')) {

I think this is the current reason why this case failed here. wrong using check_var changed to correct get_var while this test flow is wrong originally but never entered here for the wrong using of check_var.

For autoyast, it should be inst-bootmenu -> inst-bootmenu-boot-harddisk -> grub2.

So the code need to be updated to correct flow.

Actions
Copy link
 #7

Updated by leli over 1 year ago

Created a branch to fix this issue, wait http://openqa.nue.suse.com/tests/9475375#live to verify

Actions
Copy link
 #9

Updated by leli over 1 year ago

  • Status changed from In Progress to Resolved

PR merged.

Actions
Copy link

Also available in: Atom PDF