Project

General

Profile

Actions
Copy link

action #110722

closed

coordination #90086: [epic] Refactor container tests

Refactoring ideas

Added by asmorodskyi over 2 years ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
ilausuch
Target version:
-
Start date:
2022-05-06
Due date:
% Done:

0%

Estimated time:
Tags:
containers

Description

during work on https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/14797 I found some things in AKS/EKS/GKE test code which I can not handle in term of PR which I am working on but which still needs to be handled .

  1. $service is needed only in publiccloud::basetest::provider_factory , further propagation of $service variable to publiccloud::k8s_provider and down to publiccloud::*_client entities is not needed because it is not used anywhere
  2. Initialized client object may be passed via RunArgs . I prepare patch which covers main idea I will attach it to the ticket

Files

0001-containers-remove-double-init-of-clients.patch (7.5 KB) 0001-containers-remove-double-init-of-clients.patch asmorodskyi, 2022-05-06 15:09
Actions
Copy link
 #2

Updated by jlausuch over 2 years ago

  • Status changed from New to Workable
  • Parent task set to #90086
Actions
Copy link
 #3

Updated by jlausuch over 2 years ago

  • Status changed from Workable to In Progress
  • Assignee set to ilausuch

AP: @ilausuch to investigate if this is still needed.

Actions
Copy link
 #5

Updated by ilausuch over 2 years ago

About to share the same provider by the two tests (push_containers_image_to_pc and run_container_in_k8s) can not be possible because they are using different providers (ecr/eks, ..)

Actions
Copy link
 #6

Updated by ilausuch over 2 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #7

Updated by ph03nix 3 months ago

  • Tags set to containers
Actions
Copy link

Also available in: Atom PDF