In that case the whole if block would be useless, as it would be checking the same cpanfile
again.
Currently it checks os-autoinst-distri-opensuse/cpanfile
, and if there is no Perl::Tidy entry in there, it goes into the if block and checks os-autoinst-distri-openuse/os-autoinst/cpanfile
(via readlink
).
With your change it would check os-autoinst-distri-opensuse/cpanfile
twice.
os-autoinst-distri-opensuse/tools/tidy
is a symlink to os-autoinst-distri-opensuse/os-autoinst/tools/tidy
.
It uses readlink
to find the cpanfile
from os-autoinst
: os-autoinst-distri-opensuse/os-autoinst/cpanfile
in order to grep for the Perl::Tidy version in that file.
If we moved/symlinked os-autoinst-distri-opensuse/tools/tidy
to os-autoinst-common/tools/tidy
, then thanks to the readlink
it would search for a os-autoinst-common/cpanfile
, but there is none.
That's why I suggested in comment #3 that os-autoinst-distri-opensuse/cpanfile
gets its own entry for Perl::Tidy.
If we can agree on that, then we can remove the whole if block.
The only downside is that the Perl::Tidy version needs to be manually adjusted in os-autoinst-distri-opensuse/cpanfile
from time to time.