action #109870
closed[qe-core] Remove invalid references to bsc#123456
0%
Description
Motivation¶
For a while we've had a soft-fail triggering a completely different bug, bsc#123456, which could be related to a test developer trying to circumvent the "No softfailures without a reference to a ticket or a bug".
The result is that we have ended up in an unintended scenario where soft-failures are triggered in different scenarios, and we simply don't see them, as we rarely do such extensive review. (See point in the retro about meta review).
Acceptance Criteria¶
- References to bsc#123456 are removed from workaround needles and test code.
Updated by szarate about 2 years ago
- Tags set to qe-core-april-sprint
- Project changed from 175 to openQA Tests
Updated by szarate about 2 years ago
- Description updated (diff)
- Category set to Bugs in existing tests
- Start date deleted (
2022-04-12)
Updated by szarate about 2 years ago
- Sprint set to QE-Core: April Sprint (Apr 13 - May 11)
Updated by VANASTASIADIS almost 2 years ago
- Status changed from Workable to In Progress
- Assignee set to VANASTASIADIS
Invalid references have been removed from the example case. No other references to bsc#123456 exist, both in the test dir and in the needle json files. Is this enough to close the ticket?
Updated by szarate almost 2 years ago
Bill, can you add the PRs related to the changes?
Updated by VANASTASIADIS almost 2 years ago
For this specific example case, this should be the culprit:
commit that added the reference: https://gitlab.suse.de/openqa/os-autoinst-needles-sles/-/commit/fb37335e392cba20996d147c56789b493b710a5c#2bf90071018a47da60a9512e0386f1f78b044937
commit that removed the reference: https://gitlab.suse.de/openqa/os-autoinst-needles-sles/-/commit/5a0913eae41f1a0b601a312be71c8a23473f2cb5
Dates match too.
There are also other instances where bsc#123456 was used and later removed, like
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/13953/files
And I cannot find any references to that dummy bug anywhere in the current repos. I think it's good.
Updated by szarate almost 2 years ago
Looks good enough then :), are there any needles on the opensuse side of things?
Updated by VANASTASIADIS almost 2 years ago
No, no reference of the dummy bsc anywhere on opensuse needle repo either. Resolving the ticket!
Updated by VANASTASIADIS almost 2 years ago
- Status changed from In Progress to Resolved