action #109810
closedcoordination #109569: [epic][qe-core] Unify PHP Testing
[qe-core] PHP tests unification
0%
Description
Problem description¶
Right now, all the PHP tests are set in the main_common.pm
module, for the functional versions and in mau-webserver.pm
for the maintenance ones. Also, there are dedicated modules duplicated depending on the distro version (php7_mysql.pm
and php8_mysql.pm
) for example.
Proposed solution¶
The idea is to extract all the PHP tests to a brand new created testsuite called php_tests
for example, and make them completely generic to avoid code duplication. This way, instead of having two diferent modules with the same code and having the schedule to decide which of them execute, we will have a single file (php_mysql
for example) and inside it the version of PHP to use will be decided. Something like this is already being done in the module php_pcre.pm
:
if (is_leap('<15.0') || is_sle('<15')) {
$php = 'php5';
}
elsif (is_leap("<15.4") || is_sle("<15-SP4")) {
$php = 'php7';
}
else {
$php = 'php8';
}
Further improvement¶
As it's intended to make more intense tests due to the inclusion of Laravel, much more modules can be added to this testsuite in order to check for all the framework requirements.
Updated by szarate over 2 years ago
- Category set to Refactor/Code Improvements
- Status changed from New to Workable
- Target version set to QE-Core: Ready
Pablo is working on this directly as follow up to #100940
Updated by szarate over 2 years ago
- Subject changed from PHP tests unification to [qe-core] PHP tests unification
Updated by szarate over 2 years ago
Is the status of this ticket current? any updates? can we resolve the ticket?
Updated by szarate over 2 years ago
- Sprint set to QE-Core: April Sprint (Apr 13 - May 11)
Updated by pherranz over 2 years ago
I think the code for this is almost done. I'll run some VR's ASAP and then I'll open a PR.
Updated by pherranz over 2 years ago
By now, the module "web-scripting-module" is not included by default in the SLE instalations available in openQA, so there's need to create a new install with AutoYAST for this new testsuite.
In the meantime, as a workaround, all the new tests can replace the current ones in the current schedules.
Updated by szarate over 2 years ago
- Sprint deleted (
QE-Core: April Sprint (Apr 13 - May 11))
Updated by pdostal about 2 years ago
- Status changed from Workable to In Progress
- Assignee set to pdostal
I'm continuing after Pablo in https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/15536
Updated by pdostal about 2 years ago
- Status changed from In Progress to Resolved