Project

General

Profile

action #108554

[ux][ui] Wrong formatting on some links in single quotes includes trailing quotes to the link

Added by VANASTASIADIS 3 months ago. Updated 3 months ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Feature requests
Target version:
Start date:
2022-03-18
Due date:
% Done:

0%

Estimated time:
Difficulty:
Tags:

Description

Observation

When trying to use openqa-clone-custom-git-refspec with NEEDLES_GIT_REFSPEC, openqa is unable to use the needle's link. In the details of the failed job, in the spot where it mentions the problem, it includes that link inside quotes as information. However, clicking on the link to open it includes the trailing quote in the address, leading to a 404 response (which can be fixed by manually removing the trailing quote in the address bar).

An example of this can be observed here. Near the bottom of the page, there are 3 occurrences of the link 'https://gitlab.suse.de/VANASTASIADIS/os-autoinst-needles-sles/tree/imagemagick_needles'. All three lead to a 404 page, but removing the trailing quote leads to the correct page.

Steps to reproduce

  • Run openqa-clone-custom-git-refspec <valid pr link> <valid job-to-clone link> MAX_JOB_TIME=7593869 NEEDLES_GIT_REFSPEC=<valid needle branch link> _GROUP=0 _SKIP_POST_FAIL_HOOKS=1
  • Go to the resulting openqa link and wait until the job fails
  • Go near the bottom of the screen and click on the needle link

Problem

It seems to be a formatting problem, and it's probably not affecting the actual use of the link in the code, as the opening quote exists too and is not part of the link. It should however be ensured that this is the case.

Suggestion

  • ensure it is a pure formatting bug
  • locate corresponding code
  • fix it so trailing quotes are not part of the link

openqa-clone-custom-git-refspec MAX_JOB_TIME=7593869 NEEDLES_GIT_REFSPEC= _GROUP=0 _SKIP_POST_FAIL_HOOKS=1

History

#1 Updated by okurz 3 months ago

  • Category set to Feature requests
  • Priority changed from Normal to Low
  • Target version set to future

Thanks for the report.

#2 Updated by okurz 3 months ago

  • Tags set to ux, ui
  • Subject changed from [tools] Wrong formatting on some links in single quotes includes trailing quotes to the link to [ux][ui] Wrong formatting on some links in single quotes includes trailing quotes to the link

#3 Updated by okurz 3 months ago

We might want to take a look how https://github.com/sindresorhus/linkify-urls solves that. Also maybe we can strip certain characters like ', ., , if they appear at the end of openQA urls as they are unlikely to appear in URLs we reference there

Also available in: Atom PDF