action #107005: Automatic review checklists on pull requests, especially for os-autoinst non-qemu backend tests - openQA Project - openSUSE Project Management Tool

Actions

action #107005

closed

coordination #109668: [saga][epic] Stable and updated non-qemu backends for SLE validation

coordination #109656: [epic] Stable non-qemu backends

coordination #105699: [epic] 5 whys follow-up to s390x svirt jobs incomplete with unable to extract assets:.*/var/lib/libvirt/images/a.img" size:S

Status:

Resolved

Priority:

Low

Assignee:

Category:

Feature requests

Target version:

Start date:

2022-02-14

Due date:

% Done:

Estimated time:

Description

AC1: Pull requests introducing changes to non-qemu os-autoinst backends have a review checklist so that reviewers do not forget such changes need to be tested accordingly

One important factor for myself (okurz) is that I keep forgetting or overlooking certain things in reviews because I review in multiple different projects and for each I need to look for different things, e.g. in openQA I can usually trust the automated test assuming that there are according tests added and code coverage is fine, for os-autoinst I would need to carefully try myself or ask for tests, for openQA test distributions I would need to look for according openQA verification jobs. I suggest we look for "review checklists". I am thinking of a bot like mergify that responds to pull requests with a review checklist that we can tweak per project and then reviewers can cross off the individual points of that checklist.

Related issues 1 (0 open — 1 closed)

Actions

Copied from action #106999: os-autoinst: Document the use of custom openQA backend commands to test os-autoinst changes on production workers size:M added

Actions