action #106607
closedGitHub review notifications are sent to osd-admins+os-autoinst-obs@suse.de
0%
Description
Motivation¶
The mailing list osd-admins@suse.de is generally used for alert emails. GitHub emails seem misplaced here.
Acceptance criteria¶
- AC1: GitHub review notifications are not received at osd-admins@suse.de
Suggestions¶
- Configure notification settings for insert-name-here account
- Use a different email address that's not the ml
- Filter emails somehow
Updated by okurz almost 3 years ago
Well, likely what you consider problematic is that emails are received due to the user "os-autoinst-obs" being part of the "tools team". IMHO the account shouldn't be part of that team but be separate. So I agree with the AC but not with the motivation "GitHub emails seem misplaced here." nor the suggestions. The bot user simply shouldn't be asked for review.
Updated by livdywan almost 3 years ago
okurz wrote:
Well, likely what you consider problematic is that emails are received due to the user "os-autoinst-obs" being part of the "tools team". IMHO the account shouldn't be part of that team but be separate. So I agree with the AC but not with the motivation "GitHub emails seem misplaced here." nor the suggestions. The bot user simply shouldn't be asked for review.
I don't know anything about that. If this stems from some other undesired behavior and solves both issues, fine by me.
Updated by livdywan almost 3 years ago
In Slack it was suggested that @okurz would have to remove os-autoinst-obs-workflow from the team, on account of being the owner.
I checked the list of members on the tools-team. I can't change a member's status.
Updated by okurz almost 3 years ago
- Due date set to 2022-03-09
- Status changed from New to Feedback
- Assignee set to okurz
I removed "os-autoinst-obs-workflow" from the github tools team as nobody seems to remember why we would need it on the team. Let's see what this breaks.
Updated by tinita almost 3 years ago
We don't need it on the team, but the user has to be able to create github webhooks for the projects.
So please give it the permission to do so.
Updated by okurz almost 3 years ago
I created a new team "obs-integration-bot" in https://github.com/orgs/os-autoinst/teams/obs-integration-bot/members and added that team on https://github.com/os-autoinst/os-autoinst/settings/access and https://github.com/os-autoinst/openQA/settings/access with role "Write". If I understand correctly custom roles to fine-tune would only be possible in github enterprise according to https://docs.github.com/en/enterprise-cloud@latest/organizations/managing-peoples-access-to-your-organization-with-roles/managing-custom-repository-roles-for-an-organization . I don't know, how can we check if that works?
Updated by tinita almost 3 years ago
I get a 404 for https://github.com/os-autoinst/os-autoinst/settings/access and https://github.com/os-autoinst/openQA/settings/access
I set it to "Admin" instead of "Write" and now it works.