action #105127: Use more perl signatures - openQA - some simple classes size:S - openQA Project (public) - openSUSE Project Management Tool

Actions

action #105127

closed

coordination #80142: [saga][epic] Scale out: Redundant/load-balancing deployments of openQA, easy containers, containers on kubernetes

coordination #99579: [epic][retro] Follow-up to "Published QCOW images appear to be uncompressed"

coordination #99660: [epic] Use more perl signatures in our perl projects

Use more perl signatures - openQA - some simple classes size:S

Added by okurz almost 3 years ago. Updated almost 3 years ago.

Status:

Resolved

Priority:

Low

Assignee:

kodymo

Category:

Feature requests

Target version:

Ready

Start date:

Due date:

% Done:

Estimated time:

Description

Acceptance criteria¶

AC1: Some method signatures have been introduced

Suggestions¶

In https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/CLI/api.pm#L5 replace use Mojo::Base 'OpenQA::Command'; with use Mojo::Base 'OpenQA::Command', -signatures;
In https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/CLI/api.pm#L18 do what I did with https://github.com/os-autoinst/openQA/pull/4201/files . At best create a pull request already with just this line change or conduct tests locally first
Read about signatures in https://docs.mojolicious.org/perlsub#Signatures
Extend as many other references as you can

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by okurz almost 3 years ago

Copied from action #100967: Use more perl signatures - openQA size:M added

Actions

Copy link

Updated by livdywan almost 3 years ago

Subject changed from Use more perl signatures - openQA - some simple classes to Use more perl signatures - openQA - some simple classes size:S
Description updated (diff)
Status changed from New to Workable

Actions

Copy link

Updated by kodymo almost 3 years ago

Status changed from Workable to In Progress
Assignee set to kodymo

Actions

Copy link

Updated by kodymo almost 3 years ago

Signatures changed for openQA/lib/OpenQA/CLI/api.pm and archive.pm

https://github.com/os-autoinst/openQA/pull/4466

Actions

Copy link

Updated by livdywan almost 3 years ago

Status changed from In Progress to Feedback

kodymo wrote:

Signatures changed for openQA/lib/OpenQA/CLI/api.pm and archive.pm

https://github.com/os-autoinst/openQA/pull/4466

Merged - does this conclude the ticket or were you planning on proposing another branch?

Actions

Copy link

Updated by okurz almost 3 years ago

As discussed in the daily we can continue for some more changes in a row before concluding the ticket regardless if all methods in openQA introduced signatures or not :)

Actions

Copy link