action #105127: Use more perl signatures - openQA - some simple classes size:S - openQA Project - openSUSE Project Management Tool

action #105127

coordination #80142: [saga][epic] Scale out: Redundant/load-balancing deployments of openQA, easy containers, containers on kubernetes

coordination #99579: [epic][retro] Follow-up to "Published QCOW images appear to be uncompressed"

coordination #99660: [epic] Use more perl signatures in our perl projects

Use more perl signatures - openQA - some simple classes size:S

Added by okurz over 1 year ago. Updated over 1 year ago.

Status:

Resolved

Priority:

Low

Assignee:

kodymo

Category:

Feature requests

Target version:

Ready

Start date:

Due date:

% Done:

Estimated time:

Difficulty:

Description

Acceptance criteria¶

AC1: Some method signatures have been introduced

Suggestions¶

In https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/CLI/api.pm#L5 replace use Mojo::Base 'OpenQA::Command'; with use Mojo::Base 'OpenQA::Command', -signatures;
In https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/CLI/api.pm#L18 do what I did with https://github.com/os-autoinst/openQA/pull/4201/files . At best create a pull request already with just this line change or conduct tests locally first
Read about signatures in https://docs.mojolicious.org/perlsub#Signatures
Extend as many other references as you can

Related issues

History

#1 Updated by okurz over 1 year ago

Copied from action #100967: Use more perl signatures - openQA size:M added

#2 Updated by cdywan over 1 year ago

Subject changed from Use more perl signatures - openQA - some simple classes to Use more perl signatures - openQA - some simple classes size:S
Description updated (diff)
Status changed from New to Workable

#3 Updated by kodymo over 1 year ago

Status changed from Workable to In Progress
Assignee set to kodymo

#4 Updated by kodymo over 1 year ago

Signatures changed for openQA/lib/OpenQA/CLI/api.pm and archive.pm

https://github.com/os-autoinst/openQA/pull/4466

#5 Updated by cdywan over 1 year ago

Status changed from In Progress to Feedback

kodymo wrote:

Signatures changed for openQA/lib/OpenQA/CLI/api.pm and archive.pm

https://github.com/os-autoinst/openQA/pull/4466

Merged - does this conclude the ticket or were you planning on proposing another branch?

#6 Updated by okurz over 1 year ago

As discussed in the daily we can continue for some more changes in a row before concluding the ticket regardless if all methods in openQA introduced signatures or not :)