action #102350
closed
Move openqa-review CI to Github Actions
Added by tinita over 2 years ago.
Updated over 2 years ago.
Description
Observation¶
https://app.travis-ci.com/github/os-autoinst/openqa_review
Builds have been temporarily disabled for public repositories due to a negative credit balance. Please go to the Plan page to replenish your credit balance or alter your Consume paid credits for OSS setting.
So credits are gone quite fast. We should move to GitHub Actions.
Acceptance criteria¶
- AC1: All tests running on Travis so far are run on GHA instead
AC2: Publishing to pypi works
Suggestions¶
- there's a Python Publish workflow template using
pypa/gh-action-pypi-publish
- Copied from action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M added
- Priority changed from High to Normal
I don't see this as urgent though. We might just be ok with waiting as the project is not under rapid development. Honestly I would not even have added it to the backlog immediately. If you can't get it to work soon please move it out of the backlog again
okurz wrote:
We might just be ok with waiting as the project is not under rapid development.
So we wait until december for open pull requests?
- Copied from deleted (action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M)
- Blocks action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M added
- Blocks deleted (action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M)
- Related to action #102200: openqa-review pipeline failed: 'NoneType' object is not subscriptable, or failed with `assert self.issue_type == "bugzilla"` size:M added
Meh, I am stupid. travis CI checks are actually not triggered at all! :D
- Status changed from New to In Progress
- Related to action #102590: openqa_review: pypi publishing based on every git commit in master, not just tags (was: Uploading to pypi stopped, also no git tags any more after 1.25.0) added
- Description updated (diff)
Publishing to pypi is handled in #102590
- Description updated (diff)
- Status changed from In Progress to Feedback
- Status changed from Feedback to In Progress
I think I got doctest in combination with coverage working.
./.tox/cov/bin/py.test --cov=openqa_review --doctest-modules openqa_review/*
./.tox/cov/bin/py.test --cov=openqa_review --cov-append
I added a dummy function with a doctest, and coverage was 100%
Will put it into the workflow tomorrow.
- Status changed from In Progress to Resolved
PR was merged.
We now have all tests running on GHA including doctests and coverage.
Also available in: Atom
PDF