Project

General

Profile

action #101734

Prevent "called on undefined file descriptor" in myjsonrpc.pm:40 in openQA t/full-stack.t

Added by okurz about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Concrete Bugs
Target version:
Start date:
2021-10-29
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

from https://app.circleci.com/pipelines/github/os-autoinst/openQA/8274/workflows/73a4ca40-514e-44d7-a1d4-7fdf5c8ed7c1/jobs/78343?invite=true#step-111-3734

# myjsonprc: called on undefined file descriptor at /home/squamata/os-autoinst/myjsonrpc.pm line 40.
#   myjsonrpc::send_json(undef, HASH(0x55ae6f258cf8)) called at /home/squamata/os-autoinst/OpenQA/Isotovideo/CommandHandler.pm line 211
#   OpenQA::Isotovideo::CommandHandler::_handle_command_resume_test_execution(OpenQA::Isotovideo::CommandHandler=HASH(0x55ae6f24e158), HASH(0x55ae6f259178), "resume_test_execution") called at /home/squamata/os-autoinst/OpenQA/Isotovideo/CommandHandler.pm line 69
#   OpenQA::Isotovideo::CommandHandler::process_command(OpenQA::Isotovideo::CommandHandler=HASH(0x55ae6f24e158), GLOB(0x55ae6dd9bc38), HASH(0x55ae6f259178)) called at /home/squamata/os-autoinst/isotovideo line 367

in https://github.com/os-autoinst/os-autoinst/blob/6790629e6348af9c13f6a641ff3d1d9402a33a65/myjsonrpc.pm#L40 we introduced the line

confess 'myjsonprc: called on undefined file descriptor' unless defined $to_fd;

so we now know a bit more where the call came from.

Acceptance criteria

  • AC1: No more perl warning about "called on undefined file descriptor" in openQA t/full-stack.t

Related issues

Related to openQA Project - coordination #98952: [epic] t/full-stack.t sporadically fails "clickElement: element not interactable" and other errorsBlocked2021-09-21

History

#1 Updated by okurz about 1 year ago

  • Related to coordination #98952: [epic] t/full-stack.t sporadically fails "clickElement: element not interactable" and other errors added

#2 Updated by mkittler about 1 year ago

  • Status changed from New to In Progress
  • Assignee set to mkittler

#3 Updated by mkittler about 1 year ago

#4 Updated by mkittler about 1 year ago

  • Status changed from In Progress to Feedback

The PR has been merged. I'm not sure whether I'd see the effect immediately in openQA's CI (due to CircleCI's caching) so I'll create a PR for testing the fullstack test stability tomorrow.

#5 Updated by tinita about 1 year ago

I guess tools/ci/autoinst.sha in openQA needs to be updated to test the latest version

#6 Updated by mkittler about 1 year ago

  • Status changed from Feedback to Resolved

After running the fullstack test 33 times in the CI the error didn't show up anymore, see https://github.com/os-autoinst/openQA/pull/4346.

I'll leave it for #98952 to evaluate whether we can consider the fullstack test fixed as a whole.

Also available in: Atom PDF