Project

General

Profile

Wiki » History » Version 26

okurz, 2016-06-07 11:35
Add "Distinguish product and test issues bugref [gh#708]"

1 3 okurz
# Introduction
2 1 alarrosa
3 3 okurz
This is the organisation wiki for the **openQA Project**.
4 1 alarrosa
5 14 okurz
{{toc}}
6
7 3 okurz
# Organisational
8 1 alarrosa
9 3 okurz
## openQA calls
10
11
Currently there are two recurring openQA calls conducted at SUSE on http://jangouts.suse.de/. If there would be more interest from the outside the call could be made on a public platform.
12
13
Both meetings should target to finish in 15 minutes each. If more time is needed, propose to stay in the call with the required subset of attendees.
14
15
Standard rules of good "standup meetings" apply here, too, e.g.
16
17
* Be on time (be there at meeting start)
18
* Be concise (help keep the time limit)
19
* Be polite
20
* focus on
21
 * what you achieved
22
 * what you plan
23
 * where did you face problems where you could use help
24
25
26
### "openQA backend coordination" call
27
28
**objectives**:
29
30
* Coordination on openQA backend development
31
32
**execution**: A regular daily call from Mon-Fri at 0900 UTC
33
34
35
### "SUSE QA test coordination" call
36
37
**objectives**:
38
39
* Coordination on openQA based test development, especially SLE products
40
* Information about important development in openQA backend by backend responsibles
41
42
**execution**: Mon + Wed, at 0930 UTC
43
44
If somebody from SUSE QA team will do back-end development he can attend the first call as well, of course.
45
46
47 13 okurz
## ticket templates
48
You can use these templates to fill in tickets and further improve them with more detail over time. Copy the code block, paste it into a new issue, replace every block marked with "<…>" with your content or delete if not appropriate.
49
50
51
### defects
52
53
Subject: `<Short description, example: "openQA dies when triggering any Windows ME tests">`
54
55
56
```
57
## observation
58
<description of what can be observed and what the symptoms are, provide links to failing test results and/or put short blocks from the log output here to visualize what is happening>
59
60
## steps to reproduce
61
* <do this>
62
* <do that>
63
* <observe result>
64
65
## problem
66
<problem investigation, can also include different hypotheses, should be labeled as "H1" for first hypothesis, etc.>
67
68
## suggestion
69
<what to do as a first step>
70
71
## workaround
72
<example: retrigger job>
73
```
74
75
example ticket: #10526
76
77
### feature requests
78
79
Subject: `<Short description, example: "grub3 btrfs support" (feature)>`
80
81
82
```
83
## User story
84
<As a <role>, I want to <do an action>, to <achieve which goal> >
85
86
## acceptance criteria
87
* <**AC1:** the first acceptance criterion that needs to be fulfilled to do this, example: Clicking "restart button" causes restart of the job>
88
* <**AC2:** also think about the "not-actions", example: other jobs are not affected>
89
90
## tasks
91
* <first task to do as an easy starting point>
92
* <what do do next>
93
* <optional: mark "optional" tasks>
94
95
## further details
96 17 okurz
<everything that does not fit into above sections>
97 13 okurz
```
98
99
example ticket: #10212
100
101 25 okurz
## pull request handling on github
102
103
As a reviewer of pull requests on github for all related repositories, e.g. https://github.com/os-autoinst/os-autoinst-distri-opensuse/pulls, apply labels in case PRs are open for a longer time and can not be merged so that we keep our backlog clean and know why PRs are blocked.
104
105
* **notready**: Triaged as not ready yet for merging, no (immediate) reaction by the reviewee, e.g. when tests are missing, other scenarios break, only tested for one of SLE/TW
106
* **wip**: Marked by the reviewee itself as "[WIP]" or "[DO-NOT-MERGE]" or similar
107
* **question**: Questions to the reviewee, not answered yet
108
109 4 okurz
# User stories
110
111 7 okurz
## User story 1
112 6 okurz
**User:** QA-Project Managment
113 4 okurz
**primary actor:** QA Project Manager, QA Team Leads
114
**stakeholder:** Directors, VP
115 1 alarrosa
**trigger:** product milestones, providing a daily status
116 7 okurz
**user story:** „As a QA project manager I want to check on a daily basis the „openQA Dashboard“ to get a summary/an overall status of the „reviewers results“ in order to take the right actions and prioritize tasks in QA accordingly.“
117 1 alarrosa
	
118 7 okurz
## User story 2
119 4 okurz
**User:** openQA-Admin
120
**primary actor:** Backend-Team
121 1 alarrosa
**stakeholder:** Qa-Prjmgr, QA-TL, openQA Tech-Lead
122 4 okurz
**trigger:** Bugs, features, new testcases
123 7 okurz
**user story:** „As an openQA admin I constantly check in the web-UI the system health and I manage its configuration to ensure smooth operation of the tool.“
124 5 okurz
125 7 okurz
## User story 3
126 1 alarrosa
**User:** QA-Reviewer
127
**primary actor:** QA-Team
128
**stakeholder:** QA-Prjmgr, Release-Mgmt, openQA-Admin
129 4 okurz
**trigger:** every new build
130 7 okurz
**user story:** „As an openQA-Reviewer at any point in time I review on the webpage of openQA the overall status of a build in order to track and find bugs, because I want to find bugs as early as possible and report them.“
131
132
## User story 4
133 1 alarrosa
**User:** Testcase-Contributor
134
**primary actor:** All development teams, Maintenance QA
135 4 okurz
**stakeholder:** QA-Reviewer, openQA-Admin, openQA Tech-Lead
136 5 okurz
**trigger:** features, new functionality, bugs, new product/package
137 1 alarrosa
**user story:** 4. „As developer when there are new features, new functionality, bugs, new product/package in git I contribute my testcases because I want to ensure good quality submissions and smooth product integration.“
138 7 okurz
139
## User story 5
140 4 okurz
**User:** Release-Mgmt
141
**primary actor:** Release Manager
142
**stakeholder:** Directors, VP, PM, TAMs, Partners
143 1 alarrosa
**trigger:** Milestones
144 7 okurz
**user story:** „As a Release-Manager on a daily basis I check on a dashboard for the product health/build status in order to act early in case of failures and have concrete and current reports.“
145
146
## User story 6
147 4 okurz
**User:** Staging-Admin
148
**primary actor:** Staging-Manager for the products
149
**stakeholder:** Release-Mgmt, Build-Team
150
**trigger:** every single submission to projects
151 8 okurz
**user story:** „As a Staging-Manager I review the build status of packages with every staged submission to the „staging projects“ in the „staging dashboard“ and the test-status of the pre-integrated fixes, because I want to identify major breakage before integration to the products and provide fast feedback back to the development.“
152
153 15 okurz
# Glossary
154
155
The following terms are used within the context of openQA:
156
157
 * ***test modules***: an individual test case in a single perl module file, e.g. "sshxterm". If not further specified a test module is denoted with its "short name" equivalent to the filename including the test definition. The "full name" is composed of the *test group* (TBC), which itself is formed by the top-folder of the test module file, and the short name, e.g. "x11-sshxterm" (for x11/sshxterm.pm)
158
 * ***test suite***: a collection of *test modules*, e.g. "textmode". All *test modules* within one *test suite* are run serially
159
 * ***job***: one run of individual test cases in a row denoted by a unique number for one instance of openQA, e.g. one installation with subsequent testing of applications within gnome
160
 * ***test run***: equivalent to *job*
161
 * ***test result***: the result of one job, e.g. "passed" with the details of each individual *test module*
162
 * ***test step***: the execution of one *test module* within a *job*
163
 * ***distri***: a test distribution but also sometimes referring to a *product* (CAUTION: ambiguous, historically a "GNU/Linux distribution"), composed of multiple ***test modules*** in a folder structure that compose ***test suites***, e.g. "opensuse" (test distribution, short for "os-autoinst-distri-opensuse")
164
 * ***product***: the main "system under test" (SUT), e.g. "openSUSE"
165
 * ***job group***: equivalent to *product*, used in context of the webUI
166
 * ***version***: one version of a *product*, don't confuse with *builds*, e.g. "Tumbleweed"
167
 * ***flavor***: a specific variant of a *product* to distinguish differing variants, e.g. "DVD"
168 1 alarrosa
 * ***arch***: an architecture variant of a *product*, e.g. "x86_64"
169 22 okurz
 * ***machine***: additional variant of machine, e.g. used for "64bit", "uefi", etc.
170
 * ***scenario***: A composition of `<distri>-<version>-<flavor>-<arch>-<scenario>@<scenario>`, e.g. "openSUSE-Tumbleweed-DVD-x86_64-gnome@64bit", nicknamed *koala*
171 15 okurz
 * ***build***: Different versions of a product as tested, can be considered a "sub-version" of *version*, e.g. "Build1234"; CAUTION: ambiguity: either with the prefix "Build" included or not)
172
173 8 okurz
# Thoughts about categorizing test results, issues, states within openQA
174
by okurz
175
176
When reviewing test results it is important to distinguish between different causes of "failed tests"
177
178
## Nomenclature
179
180
### Test status categories
181 10 okurz
A common definition about the status of a test regarding the product it tests: "false|true positive|negative" as described on https://en.wikipedia.org/wiki/False_positives_and_false_negatives. "positive|negative" describes the outcome of a test ("positive": PASSED; "negative": FAILED) whereas "false|true" describes the conclusion of the test regarding the presence of issues in the SUT or product in our case ("true": correct reporting; "false": incorrect reporting), e.g. "true negative", test successful, no issues detected and there are no issues, product is working as expected by customer. Another example: Think of testing as of a fire alarm. An alarm (event detector) should only go off (be "positive") *if* there is a fire (event to detect) --> "true positive" whereas *if* there is *no* fire there should be *no* alarm --> "true negative".
182 1 alarrosa
183 10 okurz
Another common but potentially ambiguous categorization:
184 1 alarrosa
185 10 okurz
* *broken*: the test is not behaving as expected (Ambiguity: "as expected" by whom?) --> commonly a "false positive", can also be "false negative" but hard to detect
186
* *failing*: the test is behaving as expected, but the test output is a fail --> "true positive"
187
* *working*: the test is behaving as expected (with no comment regarding the result, though some might ambiguously imply 'result is negative')
188
* *passing*: the test is behaving as expected, but the result is a success --> "true negative"
189
190 8 okurz
If in doubt declare a test as "broken". We should review the test and examine if it is behaving as expected.
191 9 okurz
192 10 okurz
Be careful about "positive/negative" as some might also use "positive" to incorrectly denote a passing test (and "negative" for failing test) as an indicator of "working product" not an indicator about "issue present". If you argue what is "used in common speech" think about how "false positive" is used as in "false alarm" --> "positive" == "alarm raised", also see https://narainko.wordpress.com/2012/08/26/understanding-false-positive-and-false-negative/
193 8 okurz
194
### Priorization of work regarding categories
195 10 okurz
In this sense development+QA want to accomplish a "true negative" state whenever possible (no issues present, therefore none detected). As QA and test developers we want to prevent "false positives" ("false alarms" declaring a product as broken when it is not but the test failed for other reasons), also known as "type I error" and "false negatives" (a product issue is not catched by tests and might "slip through" QA and at worst is only found by an external outside customer) also known as "type II error". Also see https://en.wikipedia.org/wiki/Type_I_and_type_II_errors. In the context of openQA and system testing paired with screen matching a "false positive" is much more likely as the tests are very susceptible to subtle variations and changes even if they should be accepted. So when in doubt, create an issue in progress, look at it again, and find that it was a false alarm, rather than wasting more peoples time with INVALID bug reports by believing the product to be broken when it isn't. To quote Richard Brown: "I […] believe this is the route to ongoing improvement - if we have tests which produce such false alarms, then that is a clear indicator that the test needs to be reworked to be less ambiguous, and that IS our job as openQA developers to deal with".
196 3 okurz
197 11 okurz
## Further categorization of statuses, issues and such in testing, especially automatic tests
198
By okurz
199
200
This categorization scheme is meant to help in communication in either written or spoken discussions being simple, concise, easy to remember while unambiguous in every case.
201
While used for naming it should also be used as a decision tree and can be followed from the top following each branch.
202
203
### Categorization scheme
204
205
To keep it simple I will try to go in steps of deciding if a potential issue is of one of two categories in every step (maybe three) and go further down from there. The degree of further detailing is not limited, i.e. it can be further extended. Naming scheme should follow arabic number (for two levels just 1 and 2) counting schemes added from the right for every additional level of decision step and detail without any separation between the digits, e.g. "1111" for the first type in every level of detail up to level four. Also, I am thinking of giving the fully written form phonetic name to unambiguously identify each on every level as long as not more individual levels are necessary. The alphabet should be reserved for higher levels and higher priority types.
206
Every leaf of the tree must have an action assigned to it.
207
208 12 okurz
1 **failed** (ZULU)
209 11 okurz
11 new (passed->failed) (YANKEE)
210
111 product issue ("true positive") (WHISKEY)
211
1111 unfiled issue (SIERRA)
212
11111 hard issue (KILO)
213
111121 critical / potential ship stopper (INDIA) --> immediately file bug report with "ship_stopper?" flag; opt. inform RM directly
214
111122 non-critical hard issue (HOTEL) --> file bug report
215
11112 soft issue (JULIETT) --> file bug report
216
1112 bugzilla bug exists (ROMEO)
217
11121 bug was known to openqa / openqa developer --> cross-reference (bug->test, test->bug) AND raise review process issue, improve openqa process
218
11122 bug was filed by other sources (e.g. beta-tester) --> cross-reference (bug->test, test->bug)
219
112 test issue ("false positive") (VICTOR)
220
1121 progress issue exists (QUEBEC) --> cross-reference (issue->test, test->issue)
221
1122 unfiled test issue (PAPA)
222
11221 easy to do w/o progress issue
223
112211 need needles update --> re-needle if sure, TODO how to notify?
224
112212 pot. flaky, timeout
225
1122121 retrigger yields PASS --> comment in progress about flaky issue fixed
226
1122122 reproducible on retrigger --> file progress issue
227
11222 needs progress issue filed --> file progress issue
228
12 existing / still failing (failed->failed) (XRAY)
229
121 product issue (UNIFORM)
230
1211 unfiled issue (OSCAR) --> file bug report AND raise review process issue (why has it not been found and filed?)
231
1212 bugzilla bug exists (NOVEMBER) --> ensure cross-reference, also see rules for 1112 ROMEO
232
122 test issue (TANGO)
233
1221 progress issue exists (MIKE) --> monitor, if persisting reprioritize test development work
234
1222 needs progress issue filed (LIMA) --> file progress issue AND raise review process issue, see 1211 OSCAR
235 12 okurz
2 **passed** (ALFA)
236 11 okurz
21 stable (passed->passed) (BRAVO)
237
211 existing "true negative" (DELTA) --> monitor, maybe can be made stricter
238
212 existing "false negative" (ECHO) --> needs test improvement
239
22 fixed (failed->passed) (CHARLIE)
240
222 fixed "true negative" (FOXTROTT) --> TODO split monitor, see 211 DELTA
241
2221 was test issue --> close progress issue
242
2222 was product issue
243
22221 no bug report exists --> raise review process issue (why was it not filed?)
244
22222 bug report exists
245
222221 was marked as RESOLVED FIXED
246
221 fixed but "false negative" (GOLF) --> potentially revert test fix, also see 212 ECHO
247
248
249
Priority from high to low: INDIA->OSCAR->HOTEL->JULIETT->…
250
251
### Further decision steps working on test issues
252
253
Test issues could be one of the following sources
254
255
* "accepted product changes"
256
 * product changed slightly but in an acceptable way without the need for communication with DEV+RM --> adapt test
257
 * product changed slightly but in an acceptable way found after feedback from RM --> adapt test
258
 * product changed significantly --> after approval by RM adapt test
259
260
* changes in test setup, e.g. our test hardware equipment behaves different or the network
261
* changes in test infrastructure software, e.g. os-autoinst, openQA
262
* changes in test management configuration, e.g. openQA database settings
263
* changes in the test software itself
264
265 16 okurz
# Test reviewing
266
267
There are some features in openQA for reviewing test results and common practices. Some of these features are presented here based on the pull requests from github.
268
269
## Show previous results in test results page [gh#538](https://github.com/os-autoinst/openQA/pull/538)
270
271
On a tests result page there is a tab for "previous results" showing the result of test runs in the same scenario. This shows previous builds as well as test runs in the same build. This way you can easily check and compare results from before including any comments, labels, bug references (see next section). This helps to answer questions like "Is this a new issue", "Is it reproducable", "has it been seen in before", "how does the history look like".
272
273
Querying the database for former test runs of the same scenario is a rather
274
costly operation which we do not want to do for multiple test results at once
275
but only for each individual test result (1:1 relation). This is why this is done in each individual test result and not for a complete build.
276
277
The evaluation of previous jobs is limited but can be adjusted with the query parameter `limit_previous=<nr>` in the test URL, e.g. to provide a link to the tab in the results page showing the previous 30 results of test 1234 on openqa.opensuse.org you would write
278
`http://openqa.opensuse.org/tests/1234?limit_previous=30#previous`
279
280
Remember that the higher the limit, the more complex the database queries will be increasing the lookup time as well as the load on openQA to generate the result.
281
282
Related issue: #10212
283
284
Screenshot of feature:
285
![screenshot_20160210_142024](https://cloud.githubusercontent.com/assets/1693432/12948308/7e915a3c-d001-11e5-840b-2f070c3cb8a5.png)
286
287
288
## Show bug or label icon on overview if labeled [gh#550](https://github.com/os-autoinst/openQA/pull/550)
289
290
* Show bug icon with URL if mentioned in test comments
291
* Show bug or label icon on overview if labeled
292
293
For bugreferences write `<bugtracker_shortname>#<bug_nr>` in a comment, e.g. "bsc#1234", for generic labels use `label:<keyword>` where `<keyword>` can be any valid character up to the next whitespace, e.g. "false_positive". The keywords are not defined within openQA itself. A valid list of keywords should be decided upon within each project or environment of one openQA instance.
294
295
Example for a generic label:
296
![openqa_generic_label](https://cloud.githubusercontent.com/assets/1693432/13027322/7bce7992-d24a-11e5-99ee-839fb5e82169.png)
297
298
Example for bug label:
299
![openqa_bug_label](https://cloud.githubusercontent.com/assets/1693432/13027323/8555238a-d24a-11e5-83d5-5bb2d2140860.png)
300
301
Related issue: #10212
302
303
304
## Show certificate next to builds on overview if all failures are labeled [gh#560](https://github.com/os-autoinst/openQA/pull/560)
305
306
Based on comments in the individual job results for each build a certificate
307
icon is shown on the group overview page as well as the index page to indicate
308
that every failure has been reviewed, e.g. a bug reference or a test issue
309
reason is stated. Only the failed and incomplete jobs are regarded for the
310
evaluation if a build is considered "reviewed".
311
312
If the badge appears you know you are done for one complete build :-)
313
314
Example screenshot:
315
![openqa_reviewed_label](https://cloud.githubusercontent.com/assets/1693432/13145996/eb1bb78a-d653-11e5-9f0f-40898915578e.png)
316
317
## Allow group overview query by result [gh#531](https://github.com/os-autoinst/openQA/pull/531)
318
319
This allows e.g. to show only failed builds. Could be included like in http://lists.opensuse.org/opensuse-factory/2016-02/msg00018.html for "known defects".
320
321
Example: Add query parameters like `…&result=failed&arch=x86_64` to show only failed for the single architecture selected.
322 1 alarrosa
323 18 okurz
## Add more query parameters for configuring last builds [gh#575](https://github.com/os-autoinst/openQA/pull/575)
324
325
By using advanced query parameters in the URLs you can configure the search for builds.
326
Higher numbers would yield more complex database queries but can be selected
327
for special investigation use cases with the advanced query parameters, e.g. if one wants to get an overview of a longer history.
328
This applies to both the index dashboard and group overview page.
329
330
Example to show up to three week old builds instead of the default two weeks
331
with up to 20 builds instead of up to 10 being the default for the group
332
overview page:
333
334
    http://openqa/group_overview/1?time_limit_days=21&limit_builds=20
335 16 okurz
336 20 okurz
## Build tagging and keeping important builds [gh#591](https://github.com/os-autoinst/openQA/pull/591)
337 19 okurz
338
### Tag builds with special comments on group overview
339
340
Based on comments on the group overview individual builds can be tagged. As
341
'build' by themselves do not own any data the job group is used to store this
342
information. A tag has a 'build' to link it to a build. It also has a 'type'
343
and an optional 'description'. The type can later on be used to distinguish
344
tag types.
345
346
The more recent tag always wins.
347
348
A 'tag' icon is shown next to tagged builds together with the description on
349
the group_overview page. The index page is not changed to prevent a potential
350
performance regression.
351
352
Within the sub group_overview the comments are parsed for comments and then
353
passed to the template explicitly to prevent duplicate database queries.
354
355
### Keeping important builds
356
357
As builds can now be tagged we come up with the convention that the
358
'important' type - the only one for now - is used to tag every job that
359
corresponds to a build as 'important' and keep the logs for these jobs so that
360
we can always refer to the attached data, e.g. for milestone builds, final
361
releases, jobs for which long-lasting bug reports exist, etc.
362
363
As these jobs are not cleaned up automatically a manual or external cleanup
364
scheme has to be applied for important builds and jobs.
365
366
### Example screenshot of a tag coment and corresponding tagged build
367
![openqa_tag_important](https://cloud.githubusercontent.com/assets/1693432/13468316/4fd8f586-e0a2-11e5-99df-4aa3fb787205.png)
368
369 1 alarrosa
Related issue: #9544
370
371 23 okurz
### Carry over labels from previous jobs in same scenario if still failing [gh#564](https://github.com/os-autoinst/openQA/pull/564)
372 21 okurz
373
It is possible to label all failing tests but tedious to do by a human user
374
as many failures are just having the same issue until it gets fixed.
375
It helps if a label is preserved for a build that is still failing. This
376
idea is inspired by
377
https://wiki.jenkins-ci.org/display/JENKINS/Claim+plugin
378
379
Does not carry over labels over passes: After a job passed a new issue in a subsequent fail is assumed to be failed
380
for a different reason.
381 1 alarrosa
382
Related issue: #10212
383 23 okurz
384
385 26 okurz
### Distinguish product and test issues bugref [gh#708](https://github.com/os-autoinst/openQA/pull/708)
386
387
"progress" is used to track test issues, bugzilla for product issues, at least for SUSE/openSUSE. openQA bugrefs distinguish this and show corresponding icons
388
389
![different_bug_icons](https://cloud.githubusercontent.com/assets/1693432/15814910/e4e74bf6-2bc9-11e6-83de-20f18a7494de.png)
390
391
392 23 okurz
## Proposals for uses of labels
393
With [Show bug or label icon on overview if labeled (gh#550)](https://github.com/os-autoinst/openQA/pull/550) it is possible to add custom labels just by writing them. Nevertheless, a convention should be found for a common benefit. Beware that labels are also automatically carried over with (Carry over labels from previous jobs in same scenario if still failing [gh#564])(https://github.com/os-autoinst/openQA/pull/564) which might make consistent test failures less visible when reviewers only look for test results without labels or bugrefs.
394
395
List of proposed labels with their meaning and where they could be applied.
396
397
* ***`fixed_<build_ref>`***: If a test failure is already fixed in a more recent build and no bug reference is known, use this label together with a reference to a more recent passed test run in the same scenario. Useful for reviewing older builds. Example (https://openqa.suse.de/tests/382518#comments):
398
399
```
400
label:fixed_Build1501
401
402
t#382919
403
```
404
405 24 okurz
* ***`needles_added`***: In case needles were missing for test changes or expected product changes caused needle matching to fail, use this label with a reference to the test PR or a proper reasoning why the needles were missing and how you added them. Example (https://openqa.suse.de/tests/388521#comments):
406
407
```
408
label:needles_added
409
410
needles for https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/1353 were missing, added by jpupava in the meantime.
411
```
412
413 19 okurz
414 3 okurz
# Old content
415
## Sprints
416 2 okurz
417 1 alarrosa
418
[[Sprint 01]]
419
[[Sprint 02]]
420
[[Sprint 03]]