Project

General

Profile

action #176823

Updated by livdywan 15 days ago

## Observation 

 See documentation for `post_run_hook`(<https://open.qa/docs/#_post_run_hook>): `post_run_hook`(https://open.qa/docs/#_post_run_hook): 
 > It is called after run() regardless of the result of the test run. 

 This is not correct. The hook will not run if the test fails, see [reproducer](https://openqa.opensuse.org/tests/4842740/modules/reproducer/steps/5) where only `post_fail_hook` is executed. 

 ## Acceptance criteria 
 * **AC1**: post_run_hook documentation matches the behavior Expected result 

 ## Suggestions 
 * Either both hooks are executed or the documentation mentions that `post_run_hook` will not be called in some cases. 
 * Investigate if this is expected behavior - apparently this has not changed recently 
 * Check whether there was a reason for this. Maybe we actually want in case of a failure only the `post_fail_hook`. So perhaps it is best to just update the documentation (would be ok with    @jbaier_cz who created the ticket for its own distri). 
 * Related: #13868

Back