Project

General

Profile

action #167803

Updated by okurz 6 months ago

## Observation 
 https://app.codecov.io/gh/os-autoinst/openQA/pull/5978/indirect-changes 
 Seen in 
 * https://github.com/os-autoinst/openQA/pull/5961 
 * https://github.com/os-autoinst/openQA/pull/5978 
 `lib/OpenQA/Shared/Controller/Running.pm` 
 ``` 
      # setup a function to stop streaming again 
      my $timer_id; 
      my $close_connection = sub ($self, @) {       # line 204-206 reported as uncovered 
          Mojo::IOLoop->remove($timer_id); 
          $self->finish; 
      }; 
 
      # setup a recurring timer to send the last screenshot to the client 
 ``` 

 ## Acceptance criteria 
 * **AC1:** The code is marked as covered in Codecov 

 ## Suggestions 
 * Run the tests locally and check if the code is executed or not 
 * Evaluate if the lines can be marked as uncoverable

Back