Project

General

Profile

action #167272

Updated by okurz about 2 months ago

## Observation 

 Seen in 
 * https://github.com/os-autoinst/openQA/pull/5910 
 * https://github.com/os-autoinst/openQA/pull/5943 

 https://app.codecov.io/gh/os-autoinst/openQA/pull/5910/indirect-changes 

 Allegedly the subroutine `scheduler_step` is not covered: 
 ``` 
      note "No worker with ID $id active";      # uncoverable statement 
  } 
 
  sub scheduler_step { OpenQA::Scheduler::Model::Jobs->singleton->schedule() } 
 
  my $worker_settings = [$api_key, $api_secret, "http://localhost:$mojoport"]; 
 ``` 
 Looking at the Devel::Cover HTML report in the artifacts 
 https://output.circle-artifacts.com/output/job/c7f4dc57-bc3f-4b5d-b590-060b89c7e75e/artifacts/0/cover_db/t-05-scheduler-full-t.html 
 line 100 has a zero, although we see in line 106 and others, that this subroutine is executed. 
 Locally I cannot reproduce it. 

 ## Acceptance criteria 
 * **AC1:** codecov checks in pull requests again all pass including t/ 

 ## Suggestions 
 * Try to reproduce locally with coverage analyis enabled, e.g. `make coverage KEEP_DB=1 FULLSTACK=1 TESTS=t/05-scheduler-full.t` 
 * If not reproducible easily just do code analysis and try out in PRs triggering circleCI+codecov checks online

Back