action #157339
Updated by okurz 4 months ago
## Motivation
While reviewing https://github.com/os-autoinst/os-autoinst/pull/2470 and trying t/14-isotovideo.t out I found that t/14-isotovideo.t runs into timeout of 20s so taking too long. We had cases like that in the past and should try to identify the bottleneck of that test again and improve the runtime.
## Acceptance criteria
* **AC1:** t/14-isotovideo.t consistently passes well below the timeout of 20s again locally
## Suggestions
* Run `prove -I. -v t/14-isotovideo.t` or other means to profile that test and improve the code parts taking the most time. Consider https://metacpan.org/pod/Devel::NYTProf for both the test and isotovideo itself, e.g. `perl -d:NYTProf ./isotovideo --help` or `perl -d:NYTProf ./isotovideo .`
* Run `git bisect` to find out where a regression might have come from, e.g. maybe 5eb5dfb8 "Report test module failures via exit codes" by Jose D. Gomez R
* Consider trying to improve the runtime of isotovideo itself, not only making the test faster
* It might be necessary to accept the runtime and increase the limit accordingly after a useful amount of effort had been invested and limited to optimize time
Back