Project

General

Profile

action #155908

Updated by JERiveraMoya 4 months ago

#### Motivation 
 See epic and tickets in the epic for best practices. 

 Some general summary as a hint (after reading previous tickets): 
 Main goals are to reduce for single test suite to single yaml file comparing the ones created per each architecture before and drive the schedule having different yaml default files per each architecture. The final yaml should be stored in a folder where we have the representation of each test case: schedule/yam/test_cases 
 In order to do that you have to consider if it is just about yaml or would require some code changes to make things more homogeneous, there are multiple approaches ranging from simple dropping small tested functionality in some specific architecture to some more fancy code strategy. 
 At the same time we should care of variables, basically moving all of them to job group yaml. 
 Leave out for now ppc64le, due to most of our test coverage is in PowerVM and it is not working, so verification are not possible atm. Anyway in the future most likely we will have to reduce hugely test coverage for ppc64le, so we should take that into account instead of trying to do much effort in the code due to PowerVM requires special treatment in the console or installation that only make sense to have them in textmode breaking this homogeneity that we are aiming to. 

 Specific from this test suite: 
 For ipmi we might need to create another default file due to disk selection required there (not exclusive of ipmi), basically the only difference is that `guided_hard_disks` is not empty in the this new default file. 
 Validation is different for each architecture, in general for validation is not a good idea to have such a granularity that create those schedules differences, because the installed system are quite different, for the installer is a different case because the unified installer is quite the same for all archs except some particular differences sometimes. 
 In this ticket we can attempt to do the following: 
 - Unify hibernation_enabled hibernation_disabled in single data-driven test module. 
 - Deal with these two modules: 
 ``` 
     - console/validate_partition_table_via_blkid 
     - console/validate_blockdevices 
 ``` 
 in the sense that we could also unify the way of checking the partition table when blkid is not available or if the blockdevice check can be done for all.  
 Therefore, in summary, it is not about removing those two modules but trying to make them work for all. 

 Schedules for this test suite exists in `schedule/yast/sle/guided_btrfs/`. 

 #### Acceptance criteria 
 **AC1**: Reduce yaml files for corresponding test suite over all the architectures. 
 **AC2**: Apply additional refactor to those 3 modules mentioned above and make them data-driven. 
 **AC3**: Clean-up unused files.

Back