action #154537
Updated by okurz 3 months ago
## Observation
https://suse.slack.com/archives/C02CANHLANP/p1706607385104729
> (Dominique Leuenberger) I got the case I mentioned yesterday where 'todo' seems not to list all the tests I'd expect.
https://openqa.opensuse.org/tests/overview?result=failed&result=incomplete&result=timeout_exceeded&arch=&flavor=&machine=&test=&modules=&module_re=&group_glob=¬_group_glob=&comment=&todo=1&result=failed&result=incomplete&result=timeout_exceeded&distri=opensuse&version=Tumbleweed&build=20240129&groupid=1#
- vs https://openqa.opensuse.org/tests/overview?result=failed&result=incomplete&result=timeout_exceeded&distri=microos&distri=opensuse&version=Tumbleweed&build=20240129&groupid=1
them icroos-qemu is not listed in todo, even though it only has a comment (investigation jobs) but has not actually been tagged
seems the 'todo'link losses the &distri=microos (i.e distri was defined twice in the overview, then when picking todo, only opensuse is left)
> (Oliver Kurz) yes, that's what happens. I will record that in a ticket. Thank you for the report.
## Steps to reproduce
* Go to https://openqa.opensuse.org/tests/overview?result=failed&result=incomplete&result=timeout_exceeded&distri=microos&distri=opensuse&version=Tumbleweed&build=20240129&groupid=1
* In the filter box, click "Apply"
* Observe that you get https://openqa.opensuse.org/tests/overview?result=failed&result=incomplete&result=timeout_exceeded&arch=&flavor=&machine=&test=&modules=&module_re=&group_glob=¬_group_glob=&comment=&todo=1&result=failed&result=incomplete&result=timeout_exceeded&distri=opensuse&version=Tumbleweed&build=20240129&groupid=1# with just "distri=opensuse" and we lost "distri=microos"
## Acceptance criteria
* **AC1:** Clicking "Apply" in the /tests/overview filter box should preserve all multiple distri entries as before
## Suggestions
* Look into the latest changes in openQA code when we introduce group_glob which might have caused a regression
* Read https://github.com/os-autoinst/openQA/pull/5411 and https://github.com/os-autoinst/openQA/pull/5388
* It might be necessary to look into Perl code *and* javascript
* Extend test cases, possible in t/10-tests_overview.t
* Consider running the newly added test case against a code base before introduction of group_glob or just fix right away
Back