Project

General

Profile

action #155062

Updated by okurz 5 months ago

## Motivation 
 See #138416 

 ## Acceptance criteria 
 * **AC1:** At least os-autoinst os-autoinst&openQA inherit perl tidy perltidy&perlcritic checks from os-autoinst-common 
 * **AC2:** Checks in openQA and os-autoinst still run successfully on the master branch 
 * **AC3:** os-autoinst-distri-opensuse tidy checks still work (as they are inherited from os-autoinst) 

 ## Suggestions 
 * Follow the existing pull requests request 
 * Ensure that os-autoinst as an example works with the updated os-autoinst-common changes 
 * Note that the existing tools/tidy is used from os-autoinst-distri-opensuse via [cloning os-autoinst](https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/Makefile#L11). And then `tidy` [uses readlink to find out the right cpanfile to get the perltidy version](https://github.com/os-autoinst/os-autoinst/blob/master/tools/tidy#L78). So tools/tidy shouldn't be deleted before os-autoinst-distri-opensuse is also using os-autoinst-common 

 

Back