Project

General

Profile

action #42047

Updated by dheidler 12 months ago

## Observation 
 Apparently (non) keyframes are not marked correctly in the OGG stream produced by `videoencoder.cpp`: 
 ``` 
 mpv https://openqa.suse.de/tests/2125363/file/video.ogv 
 Playing: https://openqa.suse.de/tests/2125363/file/video.ogv 
 [ffmpeg/demuxer] ogg: Broken file, keyframe not correctly marked. 
  (+) Video --vid=1 (theora 1024x768) 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, non-keyframe not correctly marked. 
 [ffmpeg/demuxer] ogg: Broken file, keyframe not correctly marked. 
 ``` 
 (similar output with ffplay) 

 ## Acceptance criteria 
 * **AC1:** No error reports about non-keyframe not correctly marked in OGV generated video 
 * **AC2** No error reports about keyframe not correctly marked in OGV generated video 

 ## Suggestions 
 * Quickly check if with simple code changes the above error message can be prevented (at best fixed for good), otherwise state somewhere that such error messages need to be ignored and "ffmpeg" should be installed for a better experience 
 * Confirm that ffmpeg-generated videos do not have such error 


 ## Further details 
 Likely this is not a problem for the new encoder use of ffmpeg when available

Back