Project

General

Profile

action #130258

Updated by okurz over 1 year ago


 ## Observation 

 We have these warnings in our logs, very rarely though: 
 ``` 
 [2023-05-03T08:40:57.434993Z] [warn] [pid:14091]    42-inst-oninstallation-uefi-20150922.json            |    16 ----- 
  42-inst-oninstallation-uefi-20150922.png             | Bin 132801 -> 0 bytes 
  ...tallation_overview-Staging_Update-20180208.json |    16 ----- 
  ...stallation_overview-Staging_Update-20180208.png | Bin 48575 -> 0 bytes 
  DIALOG-packages-notifications-20190105.json          |    15 ----- 
  DIALOG-packages-notifications-20190105.png           | ... 
 ... 
  zypper-zdup-finish-20201012.png                      | Bin 4912 -> 0 bytes 
   14597 files changed, 12160 insertions(+), 139070 deletions(-) 
 warning: exhaustive rename detection was skipped due to too many files. 
 warning: you may want to set your diff.renameLimit variable to at least 13439 and retry the command.Bin 67666 -> 0 bytes 

 ``` 
 This apparently comes from 
 https://openqa.opensuse.org/tests/3296915#investigation 


 ## Acceptance criteria 
 * **AC1:** `needles_diff_stat` is not slowing down the investigation tab 
 * **AC2:** We are not alerted about those don't get git warnings 

 ## Suggestions 
 * See #110677 for a related fix for `git_log_diff` and comments about what to do about `needles_diff_stat` 
 * Use output from `git rev-list --count` to decide if the needle diff stat should be rendered at all 
 * Use a configurable limit (compare to git log limit of 200) 

 ## Out of scope 
 * Point to a remote diff, e.g. on github

Back