action #115343
Updated by szarate over 1 year ago
## Observation
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/15359/files#diff-899551b3c4ac5af9208cd174eeddc57854657227314a60458fcc9ceccb93c9e4R1258 tries to introduce
```
record_soft_failure("Guest $self->{guest_name} unattended installation file hosted on local host can not be reached", "Mark guest installation as FAILED. The unattended installation file url is $self->{guest_installation_automation_file}");
```
which should have failed in https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/Makefile#L154 due to missing ticket reference.
## Expected result
`record_soft_failure` without issue reference should fail CI checks
## Suggestions
1. Create a commit that adds the line mentioned in the observation (so that the bug is reproduced)
1. Rewrite the regexp (if needed) to cover the case (https://regex101.com/ can be also used to verify)
## Acceptance criteria
1. static checks are able to capture `record_soft_failure` without a ticket reference.
1. existing calls that have no bugref, are replaced with a `record_info` with a type soft-fail
1. Create a PR to add the rule to the Contributing.md in the Coding Style section.