Project

General

Profile

action #101376

Updated by okurz over 2 years ago

## Motivation 

 #97763 implemented triggers on finished jobs via `minion_task_triggers/on_job_done=`. This would be great to enable by default, especially since currently no clean-up will ever be performed by default. 

 ## Acceptance criteria 

 * **AC1:** Use cleanup triggers on finished jobs by default 

 ## Suggestions 

 - Consider removing the dependency on the systemd timer and ensure that production instances still run cleanup after the update 
  * Research how to properly communicate these changes based on systemd files, if no better way is found, just do it and tell our usual users, e.g. ping in pull request -> #101602 
 - Get familiar with [timers and triggers](https://open.qa/docs/#_timers_and_triggers) 
 - Test the impact on performance, e.g. trigger 1k tiny jobs which trigger cleanup on done 
 - Ensure that the df-check is enabled along with enabling the config 
 - Add a default config for `minion_task_triggers/on_job_done=` in etc/openqa/openqa.ini (not in code so that existing instances are not changed) 
 - Ensure that the configured cleanup jobs cover the same as the existing systemd timer 

Back