Project

General

Profile

action #98655

Updated by livdywan over 2 years ago

## Observation 
 https://github.com/os-autoinst/openQA/pull/4205 is a "dependency" update PR which should really be unrelated to coverage changes but there is a report about a coverage drop 

 ``` 
 lib/OpenQA/Worker/Job.pm  	 99.55% <0.00%> (-0.15%)  	 arrow_down 
 ``` 

 ## Acceptance criteria 
 * **AC1:** The problematic code path which should cover this line at least once is covered consistently handled explicitly 

 ## Suggestions 

 As the uncovered line is 

 ``` 
 sub settings                    { shift->{_settings} } 
 ``` 

 - we could mark the individual line as uncoverable or check where it should have been called an ensure it *is* called in tests. 
 - check the code path to the settings for bugs, maybe it's not called correctly/reliably 
 - mark the individual line as uncoverable? it doesn't look like e.g. an exit or busy loop, though (last resort)

Back