Project

General

Profile

coordination #96596

Updated by szarate over 3 years ago

## Story 

 As a code reviewer I would like the CI to do menial checks 
 so that I can focus on bigger details and be more effective with my work. details. 

 ## Background 

 Often when doing the reviews on GH, reviewers tend to mention when: 

 * File header not being updated 
 * File without summary and mantainer field 
 * Things like if check_var('ARCH') instead of is_aarch64 being wildly used, when there is `Utils::Architectures` and the same for backends 
 * Mix between `my $self = shift` and `my ($self) = @_` 
 * Failures in the tidy checks that are often hard to find (Meaning, can we get comments on the offending lines?) 
 * Know which jobs would be possibly affected by certain code changes 

 Implementing checks for each one of those items, and adding them to the [contributing](https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/CONTRIBUTING.md#coding-style) document, would be huge benefit. 


Back