Project

General

Profile

action #94901

Updated by okurz almost 3 years ago

## Motivation 
 The tests overview page doesn't validate its input. Omitting the group leads to the site picking up *some* results from the entire db. Invalid values lead to server errors. 

 Examples: 
 - https://openqa.opensuse.org/tests/overview?flavor= https://openqa.opensuse.org/tests/overview 
 - https://openqa.opensuse.org/tests/overview?groupid=spam 
 - https://openqa.opensuse.org/tests/overview?groupid=-5 

 ## Acceptance criteria 
 * **AC1:** Document use case w/o group 
 * **AC2:** Request fails if invalid flavor is groups are specified 

 ## Suggestion 
 - Add message to web UI e.g. "showing failed results from all groups" or something 
 - Add parameter validation to lib/OpenQA/WebAPI/Controller/Test.pm for simple, obvious cases

Back