Project

General

Profile

action #80274

Updated by okurz over 3 years ago

## Motivation 
 See #55364 : codecov reports often report about coverage changes which are obviously not related to the actual changes of a PR, e.g. when documentation is changed. We can already trust our coverage analysis more but should have only coverage changes reported for actual changes we introduced in a pull request. 

 ## Acceptance criteria 
 * **AC1:** t/lib/OpenQA/Test/Utils.pm does not appear anymore as changing code coverage in unrelated changes 

 ## Acceptance tests 
 * **AT1-1:** codecov reports in PRs do not reference t/lib/OpenQA/Test/Utils.pm in about 20 PR CI runs (except where t/lib/OpenQA/Test/Utils.pm is actively changed) 

 ## Suggestions 

 * See https://codecov.io/gh/os-autoinst/openQA/src/master/t/lib/OpenQA/Test/Utils.pm for a generic overview 
 * Try to reproduce locally with `rm -rf cover_db/ && make coverage KEEP_DB=1 TESTS=t/05-scheduler-full.t SCHEDULER_FULLSTACK=1` 
 * check coverage details in generated html report, e.g. call `firefox cover_db/coverage.html` 
 * Fix uncovered lines with "uncoverable" statements, see previous commits adding these comments or look into https://metacpan.org/pod/Devel::Cover#UNCOVERABLE-CRITERIA or other means 
 * retry multiple times to check for flakyness 
 * fix code sections that show unpredictable behaviour

Back