Project

General

Profile

action #91638

Updated by okurz 5 months ago

## Motivation

Our currenty Javascript linter js-beautify lives up to its name, the code looks a bit nicer but it doesn't cover much. It'd be desirable to flag more logical aspects like uses of const and not just aesthestics of the code.

## Acceptance criteria
* **AC1:** semistandard and more common javascript code styles are ensured


## Suggestions

- Use [Standard](https://github.com/standard/standard), see proof of concept: https://github.com/os-autoinst/openQA/pull/3811
- Use Semi-Standard, which has semicolons!
- Use ESLint with Semi-Standard to get even better linting and arguably go with something that works for most node projects out there
- Example for GHA https://github.com/mojolicious/server-starter/blob/master/.github/workflows/test.yml#L22 (https://github.com/mojolicious/server-starter/blob/master/package.json#L27)
- Failures look like this: https://github.com/mojolicious/server-starter/runs/2385146947?check_suite_focus=true
- According to @kraih using eslint in GHA annotates the code in the PR

Back