Project

General

Profile

action #80492

Updated by okurz about 4 years ago

## Observation 
 On https://openqa.opensuse.org/not_found one sees 

 ``` 
 +/test_suites/:id     	 PUT  	 test_suitesid  	 Deletes a table … 
 ``` 

 ## Problems 

 * It says "delete" for the PUT method, also POST 
 * there is no "apiv1_…" in the route name 
 * Looks like the same text is put on all methods here 
 * Maybe same problem appears for other routes 

 ## Suggestions 
 * Find the route definitions in https://github.com/os-autoinst/openQA/blob/master/lib/OpenQA/WebAPI.pm#L389 
 * Crosscheck and correct the "name" parameter 
 * Correct the comment that is defined in lib/OpenQA/WebAPI/Controller/API/V1/Table.pm and either incorrectly read out or needs to be updated. likely the method "_verify_table_usage" has just in the middle between the correct comment for "update" and the method definition it self

Back