Project

General

Profile

action #71857

Updated by livdywan over 3 years ago

## Observation 

 See https://codecov.io/gh/os-autoinst/openQA/pull/3417/changes from https://github.com/os-autoinst/openQA/pull/3418 

 Changes in t/lib/OpenQA/SeleniumTest.pm:wait_for_element t/lib/OpenQA/SeleniumTest.pm 

 ``` 
 368:          return 0; 
 ``` 

 Changes in t/34-developer_mode-unit.t:wait_for_finished_handled t/34-developer_mode-unit.t 

 ``` 
 101:              }); 
 102:          Mojo::IOLoop->one_tick; 
 103:          Mojo::IOLoop->remove($timer); 
 ``` 

 ## Acceptance criteria 

 * **AC1:** t/34-developer_mode-unit.t has 100% reliable statement coverage 

 ## Suggestions 

 * Collect coverage of the single test t/34-developer_mode-unit.t locally 
 * Optional: Reproduce the flakyness 
 * Ensure within the test that all code is explicitly called 
 * Extend to cover the line in t/lib/OpenQA/SeleniumTest.pm as well

Back