Project

General

Profile

action #69559

Updated by riafarov over 3 years ago

See parent ticket for more details. 

 https://trello.com/c/4GtDpmMo/ 

 ## Acceptance criteria 
 1. Readnig properties of new widget (YMenuBar) is implemented in rest api 
 2. REST api allows selection of YMenuBar items 
 3. YMenubutton widget support is tested for the regressions 

 ================================================= 
 Content of the trello card: 
 After quite some discussions in the context of https://trello.com/c/2AiHUCvZ/ we have agreed to introduce a menu bar in the Partitioner. See [the corresponding section](https://github.com/yast/yast-storage-ng/blob/master/doc/partitioner_ui.md#agreed-plan-so-far) of partitioner_ui.md. 

 We have such a menu bar in the AutoYaST module and maybe some others, but it's done in a not-so-convenient way (custom separate code for Qt and ncurses). 

 See also 

 https://gist.github.com/shundhammer/34c6640e8ead2cda894eb67123943afc 


 Bug (for the change log): 

 https://bugzilla.opensuse.org/show_bug.cgi?id=1175115 


 ------------------- 

 # Review 

 - PR for libyui: https://github.com/libyui/libyui/pull/169 
 - PR for the Qt UI: https://github.com/libyui/libyui-qt/pull/130 
 - PR for the NCurses UI:  
   - https://github.com/libyui/libyui-ncurses/pull/97 (contains screenshots) 
   - https://github.com/libyui/libyui-ncurses/pull/99 
 - PRs for the UI interpreter: 
   - https://github.com/yast/yast-ycp-ui-bindings/pull/53 
   - https://github.com/yast/yast-ycp-ui-bindings/pull/54 
 - PR for the Ruby bindings: https://github.com/yast/yast-ruby-bindings/pull/247 

 - PRs for dependent repos (SO version bumps): 

   - libyui-rest-api: https://github.com/libyui/libyui-rest-api/pull/8 

   - libyui-qt-pkg: https://github.com/libyui/libyui-qt-pkg/pull/92 
   - libyui-qt-graph: https://github.com/libyui/libyui-qt-graph/pull/40 
   - libyui-qt-rest-api: https://github.com/libyui/libyui-qt-rest-api/pull/6 

   - libyui-ncurses-pkg: https://github.com/libyui/libyui-ncurses-pkg/pull/43 
   - libyui-ncurses-rest-api: https://github.com/libyui/libyui-ncurses-rest-api/pull/5 

 - Follow-up to fix top level shortcuts conflicts: https://trello.com/c/fCUBIGGg/4232-tw-p3-1175142-yast-menu-bar-toplevel-shortcut-conflicts. 

 - Follow-up to enable/disable options in a MenuButton: https://trello.com/c/zVKTyqXe/4233-allow-to-menubutton-widget-to-enable-disable-items. 

Back