Project

General

Profile

action #69082

Updated by okurz over 4 years ago

## Motivation 

 In pull request reviews we discuss about javascript style. We should be able to save time to by applying an industry standard javascript style check solution in our tests. 

 ## Acceptance criteria 
 * **AC1:** javascript code is ensured to follow a common style with automatic checks within pull request checks 
 * **AC2:** javascript style checks can be called locally 
 * **AC3:** Common contributor team agrees on style rules we apply 

 ## Suggestions 

 * ~~Research what's the "industry standard" on javascript style checks~~ -> use eslint 
 * Add tests that can be called with Makefile 
 * Ensure check is called also within circle CI based tests 
 * Adapt all javascript code where it already differs from decided style rules 
 * Invite common contributors in pull request review to decide upon the applied style rules

Back