Project

General

Profile

action #39917

Updated by okurz over 4 years ago

## Observation 

 When job runs I am able to select "Jump to video" icon in "needle view" but that link leads me to "Page not found" (obviously). I think the icon should not be present, when video file is not present. 


 ## Acceptance criteria 

 * **AC1:** The video icon in "needle view" is only shown if a video is available for a job 


 ## Suggestions 

 Take a look in https://github.com/os-autoinst/openQA/blob/bd1d48efe8f696653680c92b07827ee3f795d0b4/lib/OpenQA/WebAPI/Plugin/Helpers.pm#L92 for the method that is called to create the link. Maybe we can know from the job details already available if the video is available, e.g. like in https://github.com/os-autoinst/openQA/blob/master/templates/test/downloads.html.ep#L6 we can apply a similar check in https://github.com/os-autoinst/openQA/blob/bd1d48efe8f696653680c92b07827ee3f795d0b4/templates/step/viewimg.html.ep#L83 . This probably needs `$resultfiles` passed over some javascript or something.

Back