action #54638
Updated by SLindoMansilla over 4 years ago
## Observation
Our favorite type of tickets.
Problematic piece of code:
```
sub nfs_shares_tab {
send_key 'alt-n'; # nfs shares tab
assert_screen 'nis-client-nfs-client-shares-conf';
send_key 'alt-a'; # add
wait_still_screen 4;
send_key 'alt-v'; # NFSV4 share checkbox
send_key 'alt-s'; # choose NFS server button
assert_screen 'nis-client-nfs-server';
send_key 'alt-o'; # OK
send_key 'alt-r'; # remote directory text field
type_string $setup_nis_nfs_x11{nfs_dir};
send_key 'alt-m'; # mount point text field
type_string $setup_nis_nfs_x11{nfs_dir};
send_key 'alt-o'; # OK
assert_screen 'nis-client-nfs-client-configuration';
send_key 'alt-o'; # OK
assert_screen 'nis-client-fw-opened';
send_key 'alt-f'; # finish
}
```
Here we send too many keys without checks, and even `wait_still_screen` which makes test unstable.
openQA test in scenario sle-12-SP5-Server-DVD-x86_64-nis_client@64bit fails in
[nis_client](https://openqa.suse.de/tests/3129027/modules/nis_client/steps/50)
## Acceptance Criteria ##
- **AC1:** re-work function "nfs_shares_tab":
- **AC2:** add checks (assert_screen) to avoid sporadic issue with key presses
## Test suite description
https://progress.opensuse.org/issues/9900
this is only the working part, there are few bugs
## Reproducible
Fails since (at least) Build [0242](https://openqa.suse.de/tests/3125618)
## Expected result
Last good: [0233](https://openqa.suse.de/tests/3114362) (or more recent)
## Further details
Always latest result in this scenario: [latest](https://openqa.suse.de/tests/latest?arch=x86_64&distri=sle&flavor=Server-DVD&machine=64bit&version=12-SP5&test=nis_client)
## Acceptance Criteria ##
re-work function "nfs_shares_tab":
add checks (assert_screen) to avoid sporadic issue with key presses