Project

General

Profile

action #34597

Updated by szarate about 6 years ago

From irc:  
 The Cache implemented in the worker has some racy conditions, the toggle_lock method can be a good starting point for it, but a deeper look at how SQLite is handling the locks and how the concurrency is being managed in the code is needed. 

 From irc:  

     conditions 

     foursixnine | coolo: nope it doesn't, but it's what's being used when a download is triggered. So the etag is sent to webui and all the magic of "Content has not channged" happens... however now looking at the code... I think that the racy sqlite hit, The image was being downloaded by other workers at the same time... so most likely both thought "Hey It's my turn"... and stepped on eachother's toes :(. 
     coolo | not according to the logs 
     coolo | only 3611 downloaded the iso 
     coolo | but the code is indeed racy 




Back