Project

General

Profile

action #99678

Speedup tidy

Added by okurz 8 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
2021-10-01
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Motivation

perltidy is used in multiple projects, e.g. os-autoinst, openQA and os-autoinst-distri-opensuse. In os-autoinst for me it takes already 22s for a noop, for os-autoinst-distri-opensuse considerably longer. Would be great if we can improve that. https://metacpan.org/dist/Code-TidyAll/view/bin/tidyall sounds like a good approach as it has a local file signature cache that sounds promising. But when I ran it locally on os-autoinst it changed the copyright character and eventually failed with

Wide character in print at /usr/lib/perl5/vendor_perl/5.26.1/Path/Tiny.pm line 537.
Wide character in subroutine entry at /usr/lib/perl5/vendor_perl/5.26.1/Code/TidyAll/CacheModel.pm line 125.

Acceptance criteria

  • AC1: A noop run of tidy is considerably quicker in os-autoinst-distri-opensuse
  • AC2: The same solution is applied for os-autoinst+openQA+os-autoinst-distri-opensuse

Suggestions

History

#1 Updated by okurz 7 months ago

  • Assignee set to okurz
  • Priority changed from Normal to Low

#2 Updated by okurz 4 months ago

  • Status changed from New to Feedback
  • Target version changed from future to Ready

#3 Updated by okurz 4 months ago

  • Status changed from Feedback to In Progress

CI tests fail due to missing dependency. Did

for i in perl-List-Compare perl-Specio-Library-Path-Tiny perl-lib-relative perl-Code-TidyAll; do osc sr -m "Dependency of perl-Code-TidyAll for use in os-autoinst" openSUSE:Factory $i openSUSE:Backports:SLE-15-SP4 && osc linkpac openSUSE:Factory $i devel:openQA:Leap:15.3; done

to add the perl package 'Code::TidyAll' for our repos and for future support in Leap.

#4 Updated by okurz 4 months ago

  • Status changed from In Progress to Feedback

#5 Updated by okurz 4 months ago

Both PRs merged. Preparing an equivalent change for openQA: https://github.com/os-autoinst/openQA/pull/4468

#6 Updated by okurz 4 months ago

  • Status changed from Feedback to In Progress

#7 Updated by okurz 4 months ago

  • Status changed from In Progress to Feedback

#8 Updated by okurz 3 months ago

#9 Updated by okurz 3 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF