Project

General

Profile

Actions

action #95730

closed

on o3 in openqa-webui journal: "Jul 20 08:06:54 ariel openqa-webui-daemon[31559]: Use of uninitialized value in concatenation (.) or string at /usr/share/openqa/script/../lib/OpenQA/Schema/Result/Jobs.pm line 661." size:S

Added by okurz about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2021-07-20
Due date:
% Done:

0%

Estimated time:

Description

Observation

From ssh o3 "sudo journalctl --since=today -u openqa-webui"

-- Logs begin at Wed 2021-07-07 10:02:59 UTC, end at Tue 2021-07-20 12:58:28 UTC. --
Jul 20 03:00:25 ariel systemd[1]: Stopping The openQA web UI...
Jul 20 03:00:25 ariel systemd[1]: Stopped The openQA web UI.
Jul 20 03:00:26 ariel systemd[1]: Started The openQA web UI.
Jul 20 03:00:28 ariel openqa-webui-daemon[31559]: Web application available at http://127.0.0.1:9526
Jul 20 03:00:28 ariel openqa-webui-daemon[31559]: Web application available at http://[::1]:9526
Jul 20 08:06:54 ariel openqa-webui-daemon[31559]: Use of uninitialized value in concatenation (.) or string at /usr/share/openqa/script/../lib/OpenQA/Schema/Result/Jobs.pm line 661.

with the latest line being an error Use of uninitialized value in concatenation (.) or string at /usr/share/openqa/script/../lib/OpenQA/Schema/Result/Jobs.pm line 661. that should be fixed

Steps to reproduce

TBC if ssh o3 "sudo journalctl --since=today -u openqa-webui" reproduces this after every webUI restart

Acceptance criteria

  • AC 1: The perl warning doesn't show anymore

Suggestions

https://github.com/os-autoinst/openQA/blob/694449b322142d679204e006ca1d2a8d134fb475/lib/OpenQA/Schema/Result/Jobs.pm#L661
shows

die "Job $orig_id has already been cloned as " . $self->clone_id . "\n" unless $affected_rows == 1;

with the perl warning stating that one of $orig_id or $self->clone_id could be undefined. This should be prevented.

  • try to find the reason behind of the undefined. Verify that the query of the affected line is expected to fail sometimes.
Actions #1

Updated by okurz about 3 years ago

  • Priority changed from Normal to High
Actions #2

Updated by ilausuch about 3 years ago

  • Subject changed from on o3 in openqa-webui journal: "Jul 20 08:06:54 ariel openqa-webui-daemon[31559]: Use of uninitialized value in concatenation (.) or string at /usr/share/openqa/script/../lib/OpenQA/Schema/Result/Jobs.pm line 661." to on o3 in openqa-webui journal: "Jul 20 08:06:54 ariel openqa-webui-daemon[31559]: Use of uninitialized value in concatenation (.) or string at /usr/share/openqa/script/../lib/OpenQA/Schema/Result/Jobs.pm line 661." size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions #3

Updated by tinita about 3 years ago

with the perl warning stating that one of $orig_id or $self->clone_id could be undefined. This should be prevented.

We already know that it is $self->clone_id. If $orig_id was undef the warning would be
Use of uninitialized value $orig_id in concatenation (.) or string

Actions #4

Updated by tinita about 3 years ago

  • Assignee set to tinita
Actions #5

Updated by tinita about 3 years ago

  • Status changed from Workable to Feedback
Actions #6

Updated by tinita about 3 years ago

  • Status changed from Feedback to Resolved

I haven't seen the error since the fix was rolled out.
journalctl --since=2021-07-20 -u openqa-webui

Actions

Also available in: Atom PDF