action #86081
closed[SLE-12280][SLE-15197] Hibernation proposed by Installer/Bootloader
0%
Description
See https://jira.suse.com/browse/SLE-15197
Expectations are basically available here:
https://github.com/yast/yast-yast2/pull/1115/files#diff-dca9d9f0a69c2b1db778bf3549a3476f2d37bd26a0aa549b042ed8132057f705R556
hibernation (resume
kernel parameter) is proposed for x86 only, excluding xen and kvm. On other architectures should not be proposed.
Feature description from trello:
Follow-up of https://trello.com/c/ULBrtwpz/
Dev: https://jira.suse.com/browse/SLE-15921
Epic: https://jira.suse.com/browse/SLE-12280
Adapt https://github.com/yast/yast-storage-ng/blob/master/src/lib/y2storage/arch.rb#L58 to use the new API that tells us whether hibernation is wanted/supported
Review¶
- Code adapted to use the new method.
- https://github.com/yast/yast-storage-ng/pull/1181
On s390x hibernation is not supported.
See also https://trello.com/c/ULBrtwpz/2144-3-couldhave-hibernation-proposed-by-installer-bootloader :
Dev: https://jira.suse.com/browse/SLE-15921
Epic: https://jira.suse.com/browse/SLE-12280
### Hibernation disabled by default
- HW: On all S390 and Power installations
- Virtual / Physical: In all virtual systems
- Products: In SLES, SUMA, etc. (server)
### Hibernation enabled by default
- SLED, openSUSE, TW (except if ^^^ applies)
### Implementation details
- Hibernation means "resume" in Kernel cmdline
- Expectations define both include and exclude-lists, but that does not say how the code should look like (that's out of scope here)
- Bootloader does not set "resume" parameter by default (if hibernation disabled)
- ~~Storage proposal does not show "enlarge swap for suspend" (if hibernation disabled)~~ -- let's discuss this with @ancorgs first
- User can obviously adapt bootloader config / storage as they wish
- Ask in JIRA if they want that in summary screen (enabled/disabled/...)
- Ask Ken for feedback
## Review
- https://github.com/yast/yast-installation-control/pull/104
- https://github.com/yast/yast-yast2/pull/1115
- https://github.com/yast/skelcd-control-leanos/pull/69
- https://github.com/yast/skelcd-control-SLED/pull/101
- https://github.com/yast/yast-bootloader/pull/625 and https://github.com/yast/yast-bootloader/pull/626
Updated by riafarov almost 4 years ago
- Status changed from Workable to In Progress
- Assignee set to riafarov
Updated by riafarov almost 4 years ago
- Status changed from In Progress to Feedback
Updated by riafarov almost 4 years ago
- Status changed from Feedback to Closed
There are multiple bugs related to the feature, all listed in Jira, so we will consider having second round of testing for it, besides bug validation.