Project

General

Profile

Actions

action #71146

closed

[os-autoinst][backends] Prevent undocumented test variables in backends / prevent use of external testapi methods

Added by okurz almost 4 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Motivation

We have a test for undocumented test variables t/04-check_vars_docu.t but this one only checks for variables like $bmwqemu::vars and not uses of get_var or get_required_var in our backends. Also it is a good practice to not use the external API from testapi.pm in any internal implementations.

Acceptance criteria

  • AC1: use of get_var, check_var, set_var, get_required_var is prevented in backends
  • AC2: undocumented test variables (or test variables used like get_var('FOO')) are prevented in backends

Suggestions

  • Add a test, e.g. directly in t/04-check_vars_docu.t that fails if any get_var('FOO') or alike is encountered in backends, especially if FOO is not mentioned in docs/backend_vars.asciidoc

Related issues 1 (0 open1 closed)

Copied from openQA Project - action #34303: Fix test for undocumented backend variablesResolvedilausuch2018-04-05

Actions
Actions #1

Updated by okurz almost 4 years ago

  • Copied from action #34303: Fix test for undocumented backend variables added
Actions #2

Updated by okurz over 3 years ago

  • Target version changed from Ready to future
Actions #3

Updated by okurz over 2 years ago

  • Status changed from Workable to Resolved
  • Assignee set to okurz
  • Target version changed from future to Ready
Actions

Also available in: Atom PDF