QA » openQA Project » openQA Tests

Just as the comments #40 from Egbert and my reply, we need remove '-f' of reboot in patch_sle.

(In reply to Egbert Eich from comment #40)

While this ticket has identified a weakness in the system the code for
preparing the test system is still bogus:
it was not the task to test the robustness of the SUT with respect to
certain rare and abnormal conditions and occurrences. Instead the fallout
caused by the improper way of shutting down a system is blocking progress on
performing the intended tests.
@Chenzi - so far I've not been successful to get the attention of your team
that the '-f' option to 'reboot' in 'patch_sle' is not the proper way to
reboot.

Note:

1. performing a 'sync; reboot -f' does not cause harm normally.
2. there may be some corner cases where this operation will potentially lead to problems.
3. Different system configuration may have a different susceptibility to this condition.

Bottom line: the test case needs to be fixed, the '-f' option needs to be
removed from 'reboot'.

Hi Egbert,
Thanks. In fact, I think the adding 'reboot -f' just hope to speedup the system boot to fix the timeout issue for wait_boot.
Anyway, from your description I agree that the 'reboot -f' may make potencial risk for file system. I will file a ticket to fix it.