action #64967: job templates are duplicated as job template in job groups as well as test suites - openQA Tests (public) - openSUSE Project Management Tool

Actions

Copy link

action #64967

closed

coordination #15132: [saga][epic] Better structure of test plans in main.pm

openQA Project (public) - coordination #44360: [epic] Parameterize test suites within job groups

openQA Project (public) - coordination #55730: [epic] Move parameters from test suites into job groups

job templates are duplicated as job template in job groups as well as test suites

Added by okurz over 4 years ago. Updated over 4 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

tinita

Category:

Enhancement to existing tests

Target version:

Start date:

2020-03-29

Due date:

% Done:

Estimated time:

Difficulty:

Description

Observation¶

scenario opensuse-Tumbleweed-DVD-x86_64-desktopapps-remote-desktop-xrdp-client1@64bit_virtio shows the not so helpful test suite description "The base test suite is used for job templates defined in YAML documents. It has no settings of its own." as it is defined within https://openqa.opensuse.org/admin/job_templates/1 with only '' as description. The job template is defined in https://openqa.opensuse.org/admin/job_templates/1 probably due to #60329 but I see it as a problem that we still have the test suite defined in https://openqa.opensuse.org/admin/test_suites . If this problem is there for one job template and test suite I assume the same is the case for other job templates and test suites.

Acceptance criteria¶

AC1: Job templates inheriting from "testsuite: null" are not duplicated as test suites

Suggestions¶

Check how often test suites are used on o3, if 0 times, delete it (optional: backup in before)
… if 1 time, ensure it's defined as job template and delete from test suites
… if multiple times, keep test suite and use in job templates rather than duplicating in job templates inheriting null

Further details¶

Always latest result in this scenario: latest

Files

o3-testsuites-not-used-2020-05-15.tgz (14.6 KB) o3-testsuites-not-used-2020-05-15.tgz

tinita, 2020-05-15 14:57

Actions

Copy link

Updated by okurz over 4 years ago

Parent task set to #55730

Actions

Copy link

Updated by tinita over 4 years ago

Getting all testsuites used once:

SELECT ts.id, ts.name, count(*) AS c, STRING_AGG(jt.group_id::character varying, ' ') AS ids
FROM job_templates jt INNER JOIN test_suites ts ON jt.test_suite_id=ts.id
GROUP BY ts.id, ts.name
HAVING COUNT(*) = 1
ORDER BY ts.name;

o3: 19
osd: 1009

Getting all testsuites used nowhere:

SELECT ts.id, ts.name
FROM test_suites ts
LEFT JOIN job_templates jt ON ts.id=jt.test_suite_id
WHERE jt.id IS NULL;

o3: 105
osd: 147

Actions

Copy link

Updated by okurz over 4 years ago

Status changed from New to Workable

Discussed with cdywan and tinita:
@tinita please conduct backup of all test suites or the ones you want to delete, save backup to internal share folder, e.g. w3.suse.de. For that copy the data to any computer connected to the Nbg NFS/NIS shares , for example login with ssh to login.suse.de . For o3 you can attach to this ticket, there are no precious regcodes. Then delete all unused test suites (optionally inform users).

For the "test suites just used once" tinita found some users that do not want their test suites to be moved into job group yaml templates so we will leave this point for now.

Actions

Copy link