action #60401
closed[tools] DRY aka. "reduce duplication" in method wait_boot and tests/installation/first_boot
0%
Description
Observation¶
The method "wait_boot" and the test module tests/installation/first_boot have a lot of duplicate functionality with lots of workarounds and error detection code.
Acceptance criteria¶
- AC1: No unnecessary duplication
Suggestions¶
Just call wait_boot in "tests/installation/first_boot" and add missing parts into the method wait_boot
Updated by okurz about 5 years ago
- Copied from action #38423: [sle][functional][u][hard] Refactor first_boot to unify duplicated behavior for remote backend added
Updated by okurz about 5 years ago
- Status changed from Workable to In Progress
Trying to move everything from first_boot into wait_boot, yes everything:
$ for i in 1097756 1097789 1098166 1097769 1097775 1097768 1097860 1096942 1097135; do openqa-clone-job --within-instance https://openqa.opensuse.org --parental-inheritance --skip-chained-deps $i BUILD= _GROUP=0 CASEDIR=https://github.com/okurz/os-autoinst-distri-opensuse.git#enhance/wait_boot; done
$
Created job #1098304: opensuse-Tumbleweed-DVD-x86_64-Build20191127-boot_to_snapshot@64bit -> https://openqa.opensuse.org/t1098304
Created job #1098305: opensuse-Tumbleweed-DVD-x86_64-Build20191127-extra_tests_on_kde@64bit -> https://openqa.opensuse.org/t1098305
Created job #1098306: opensuse-Tumbleweed-DVD-x86_64-Build20191127-gnome@64bit -> https://openqa.opensuse.org/t1098306
Created job #1098307: opensuse-Tumbleweed-DVD-x86_64-Build20191127-kde@64bit -> https://openqa.opensuse.org/t1098307
Created job #1098308: opensuse-Tumbleweed-DVD-x86_64-Build20191127-minimalx@64bit -> https://openqa.opensuse.org/t1098308
Created job #1098309: opensuse-Tumbleweed-DVD-x86_64-Build20191127-textmode@64bit -> https://openqa.opensuse.org/t1098309
Created job #1098310: opensuse-Tumbleweed-DVD-x86_64-Build20191127-upgrade_Leap_15.1_gnome@64bit -> https://openqa.opensuse.org/t1098310
Created job #1098311: opensuse-Tumbleweed-DVD-x86_64-Build20191126-extra_tests_in_textmode@64bit -> https://openqa.opensuse.org/t1098311
Created job #1098312: opensuse-Tumbleweed-DVD-x86_64-Build20191126-extra_tests_on_gnome@64bit -> https://openqa.opensuse.org/tests/1098346
Updated by okurz about 5 years ago
some tests already failed in production so I am excluding the modules that fail already in the original jobs.
openqa_clone_job_o3 1098475 TEST=extra_tests_in_textmode_okurz EXCLUDE_MODULES=check_os_release,firewalld,rails
Created job #1098521: opensuse-Tumbleweed-DVD-x86_64-extra_tests_in_textmode@64bit -> https://openqa.opensuse.org/t1098521
Also trying to reproduce the problem in "multi_users_dm" faster:
openqa_clone_job_o3 1098469 TEST=extra_tests_on_kde_okurz_only_multi-users-dm SCHEDULE=tests/boot/boot_to_desktop,tests/x11/multi_users_dm
Created job #1098522: opensuse-Tumbleweed-DVD-x86_64-extra_tests_on_kde@64bit -> https://openqa.opensuse.org/t1098522
openqa_clone_job_o3 1098469 TEST=extra_tests_on_kde_okurz_only_multi-users-dm SCHEDULE=tests/boot/boot_to_desktop,tests/console/prepare_test_data,tests/x11/multi_users_dm _SKIP_POST_FAIL_HOOKS=1
Created job #1098523: opensuse-Tumbleweed-DVD-x86_64-extra_tests_on_kde@64bit -> https://openqa.opensuse.org/t1098523
Fixed a problem with DM login handling.
Triggering also more to cover unlocking encrypted and more DMs:
for i in 1098706 1098643 ; do openqa-clone-job --within-instance https://openqa.opensuse.org --parental-inheritance --skip-chained-deps $i BUILD= _GROUP=0 CASEDIR=https://github.com/okurz/os-autoinst-distri-opensuse.git#enhance/wait_boot; done
Created job #1099076: opensuse-Tumbleweed-DVD-x86_64-Build20191128-gnome-gdm@64bit -> https://openqa.opensuse.org/t1099076
Created job #1099077: opensuse-Tumbleweed-DVD-x86_64-Build20191128-cryptlvm@uefi -> https://openqa.opensuse.org/t1099077
and some more for osd:
for i in https://openqa.suse.de/tests/3640804 https://openqa.suse.de/tests/3640808 https://openqa.suse.de/tests/3641653 https://openqa.suse.de/tests/3641654 https://openqa.suse.de/tests/3575689 https://openqa.suse.de/tests/3575671 https://openqa.suse.de/tests/3576836 https://openqa.suse.de/tests/3577779 https://openqa.suse.de/tests/3577780 https://openqa.suse.de/tests/3575770 https://openqa.suse.de/tests/3576330 https://openqa.suse.de/tests/3576338 https://openqa.suse.de/tests/3642307 https://openqa.suse.de/tests/3642493 https://openqa.suse.de/tests/3642684 https://openqa.suse.de/tests/3639094 ; do openqa-clone-job --parental-inheritance --skip-chained-deps --within-instance $i BUILD= _GROUP=0 CASEDIR=https://github.com/okurz/os-autoinst-distri-opensuse.git#enhance/wait_boot; done
Created job #3644083: sle-15-SP2-Full-s390x-Build97.1-skip_registration@s390x-kvm-sle12 -> https://openqa.suse.de/t3644083
Created job #3644084: sle-15-SP2-Full-s390x-Build97.1-skip_registration@s390x-zVM-vswitch-l2 -> https://openqa.suse.de/t3644084
Created job #3644085: sle-15-SP2-Online-x86_64-Build97.1-create_hdd_sles4sap_gnome@64bit-2gbram -> https://openqa.suse.de/t3644085
Created job #3644086: sle-15-SP2-Online-x86_64-Build97.1-create_hdd_sles4sap_textmode@64bit-2gbram -> https://openqa.suse.de/t3644086
Created job #3644087: sle-12-SP5-SAP-DVD-x86_64-Build0344-create_hdd_sles4sap_textmode@64bit-2gbram -> https://openqa.suse.de/t3644087
Created job #3644088: sle-12-SP5-SAP-DVD-x86_64-Build0344-create_hdd_sles4sap_gnome@64bit-2gbram -> https://openqa.suse.de/t3644088
Created job #3644089: sle-12-SP5-Server-DVD-x86_64-Build0372-autologin_yast@64bit -> https://openqa.suse.de/t3644089
Created job #3644090: sle-12-SP5-Server-DVD-ppc64le-Build0372-cryptlvm@ppc64le-spvm -> https://openqa.suse.de/t3644090
Created job #3644091: sle-12-SP5-Server-DVD-ppc64le-Build0372-cryptlvm@ppc64le -> https://openqa.suse.de/t3644091
Created job #3644092: sle-12-SP5-Server-DVD-aarch64-Build0372-cryptlvm@aarch64 -> https://openqa.suse.de/t3644092
Created job #3644093: sle-12-SP5-Server-DVD-s390x-Build0372-xfs@s390x-kvm-sle12 -> https://openqa.suse.de/t3644093
Created job #3644094: sle-12-SP5-Server-DVD-s390x-Build0372-xfs@s390x-zVM-vswitch-l2 -> https://openqa.suse.de/t3644094
Created job #3644095: sle-12-SP4-Desktop-DVD-Updates-x86_64-Build20191129-1-qam-gnome@64bit -> https://openqa.suse.de/t3644095
Created job #3644096: sle-12-SP4-Server-DVD-Updates-x86_64-Build20191129-1-qam-textmode@64bit -> https://openqa.suse.de/t3644096
Created job #3644097: sle-15-Server-DVD-Updates-x86_64-Build20191129-1-mru-install-minimal-with-addons@64bit -> https://openqa.suse.de/t3644097
Created job #3644098: sle-15-Server-DVD-Updates-x86_64-Build20191128-2-qam-gnome@64bit -> https://openqa.suse.de/t3644098
Created PR: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/9035
EDIT: Continuing with "handle_login" deduplication.
openqa_clone_job_o3 1098469 TEST=extra_tests_on_kde_okurz_only_multi-users-dm SCHEDULE=tests/boot/boot_to_desktop,tests/console/prepare_test_data,tests/x11/multi_users_dm CASEDIR=https://github.com/okurz/os-autoinst-distri-opensuse.git#enhance/wait_boot2
Created job #1099358: opensuse-Tumbleweed-DVD-x86_64-extra_tests_on_kde@64bit -> https://openqa.opensuse.org/t1099358 -> failed in logout of multi_users_dm, retriggered as https://openqa.opensuse.org/tests/1099406 all good
for i in https://openqa.opensuse.org/tests/1099076 https://openqa.suse.de/tests/3644088 https://openqa.suse.de/tests/3644086 https://openqa.suse.de/tests/3644083 https://openqa.suse.de/tests/3644084 https://openqa.suse.de/tests/3644098 ; do openqa-clone-job --parental-inheritance --skip-chained-deps --within-instance $i BUILD= _GROUP=0 CASEDIR=https://github.com/okurz/os-autoinst-distri-opensuse.git#enhance/wait_boot2; done
Created job #1099343: opensuse-Tumbleweed-DVD-x86_64-gnome-gdm@64bit -> https://openqa.opensuse.org/t1099343
Created job #3644587: sle-12-SP5-SAP-DVD-x86_64-create_hdd_sles4sap_gnome@64bit-2gbram -> https://openqa.suse.de/t3644587
Created job #3644588: sle-15-SP2-Online-x86_64-create_hdd_sles4sap_textmode@64bit-2gbram -> https://openqa.suse.de/t3644588
Created job #3644589: sle-15-SP2-Full-s390x-skip_registration@s390x-kvm-sle12 -> https://openqa.suse.de/t3644589
Created job #3644590: sle-15-SP2-Full-s390x-skip_registration@s390x-zVM-vswitch-l2 -> https://openqa.suse.de/t3644590
Created job #3644591: sle-15-Server-DVD-Updates-x86_64-qam-gnome@64bit -> https://openqa.suse.de/t3644591
all good.
ldevulder mention a problem in https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/9035#issuecomment-559811947 about sap+gnome. I think enhance/wait_boot2 fixes it as https://openqa.suse.de/tests/3644587#step/first_boot/5 looks good
Updated PR https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/9035 as it seems to fix sap+gnome
Updated by okurz about 5 years ago
- Subject changed from DRY aka. "reduce duplication" in method wait_boot and tests/installation/first_boot to [tools] DRY aka. "reduce duplication" in method wait_boot and tests/installation/first_boot
- Status changed from In Progress to Feedback
- Target version set to Current Sprint
merged