QA » openQA Project » openQA Tests

'reboot' is not typed at all:
https://openqa.suse.de/tests/1536719#step/reboot_to_upgrade/5

the test has set DESKTOP=gnome but in reboot_to_upgrade:31 you do a power_action('reboot', textmode => 1); - this looks wrong to me.

It is a new test right? did it run before on zkvm?

mgriessmeier wrote:

the test has set DESKTOP=gnome but in reboot_to_upgrade:31 you do a power_action('reboot', textmode => 1); - this looks wrong to me.

It is a new test right? did it run before on zkvm?

Hi Matthias:
It is not new test case, just modify those test suits' name and some parameters, so there is no history result. it always have DESKTOP=gnome, I don't change it.

dehai wrote:

mgriessmeier wrote:

the test has set DESKTOP=gnome but in reboot_to_upgrade:31 you do a power_action('reboot', textmode => 1); - this looks wrong to me.

It is a new test right? did it run before on zkvm?

Hi Matthias:
It is not new test case, just modify those test suits' name and some parameters, so there is no history result. it always have DESKTOP=gnome, I don't change it.

so it seems that VERSION variable was switched from 15 (last good) to 12-SP3
but I don't get it why this should be the reason for that fail :(
sorry, nevermind, different testsuite - what was the old name of the testsuite?

I mean... I've changed something in this 'reboot' code recently, but it's in a different code path as far as I can see... so I don't see the relation to be honest

sorry, nevermind, different testsuite - what was the old name of the testsuite?

Hi Matthias:
Here is the old name and link:
media_upgrade_sles12sp3+ha+sdk_allpatterns_workaround_modules
https://openqa.suse.de/tests/1532162

Hello Matthias:

Regarding to this issue, maybe we can fix it with following changes to reboot_to_upgrade.pm

diff --git a/tests/migration/reboot_to_upgrade.pm b/tests/migration/reboot_to_upgrade.pm
index 09462592..41dfb7e9 100644
--- a/tests/migration/reboot_to_upgrade.pm
+++ b/tests/migration/reboot_to_upgrade.pm
@@ -28,7 +28,8 @@ sub run {

     # Reboot from Installer media for upgrade
     set_var('BOOT_HDD_IMAGE', 0) if get_var('UPGRADE') || get_var('AUTOUPGRADE');
-    power_action('reboot', textmode => 1);
+    assert_script_run "sync", 300;
+    type_string "reboot --force\n";
 }

Because in this case "assert_shutdown_and_restore_system" is not really required, which is used to re-connect VNC session, afterwards bootloader_zkvm module will make it work. I have verified the changes above works for s390x zkvm (should also work for s390x suse kvm):
http://openqa-apac1.suse.de/tests/440#step/welcome/4

Would you please help review PR for fixing this issue:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4597

qmsu wrote:

Would you please help review PR for fixing this issue:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4597

commented on PR

Hi Matthias:

Your changes for reboot code should be fine, and seems the only problem here during upgrade is that we shouldn't use power_action('reboot') in reboot_to_upgrade, see my comment in
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/4597

PR merged