action #25572

[tools][needles]needles pushing can interfer with "fetchneedles"

Added by okurz over 2 years ago. Updated 3 months ago.

Status:ResolvedStart date:26/09/2017
Priority:NormalDue date:
Assignee:okurz% Done:

0%

Category:Feature requests
Target version:Done
Difficulty:
Duration:

Description

I just realized today after creating a needle over the webui of osd that "fetchneedles-sles" returned an error with

You are not currently on a branch.
Please specify which branch you want to rebase against.
See git-rebase(1) for details.

    git rebase <branch>

Checking after that I found out that

/var/lib/openqa/share/tests/sle/products/sle/needles

is on "(no branch)" and needs to be manually merged again.


Related issues

Related to openQA Infrastructure - action #58373: Proposal: Poll test and needle repos every minute to make... Resolved 18/10/2019
Related to openQA Project - action #58184: [epic][use case] full version control awareness within op... Workable 23/03/2018

History

#1 Updated by okurz over 2 years ago

  • Subject changed from needles pushing can interfer with "fetchneedles" to [tools][needles]needles pushing can interfer with "fetchneedles"

On osd we also have a workaround for another problem which should be taken into account although that does not seem to cause the problem

# sometimes gitlab.s.d is unresponsive and there are new needles coming in and we did not pull in time before someone created new needles from the webui so make sure this is synced at least once a day
47 3 * * * geekotest (cd /var/lib/openqa/share/tests/sle && git pull --rebase >/dev/null && git push origin HEAD:master >/dev/null 2>&1)

I wonder what is exactly happening here. I assume git already has a locking mechanism which should prevent this but maybe it's not. I guess we should adapt fetchneedles to check better the pre- and post-state, some sanity checks, you know.

#2 Updated by okurz 8 months ago

  • Category changed from 128 to Feature requests

#3 Updated by okurz 4 months ago

  • Blocked by action #58184: [epic][use case] full version control awareness within openQA, e.g. user forks and branches added

#4 Updated by okurz 4 months ago

  • Status changed from New to Blocked
  • Assignee set to okurz

#5 Updated by okurz 3 months ago

  • Related to action #58373: Proposal: Poll test and needle repos every minute to make people wait less for updates in tests or needles added

#6 Updated by okurz 3 months ago

  • Blocked by deleted (action #58184: [epic][use case] full version control awareness within openQA, e.g. user forks and branches)

#7 Updated by okurz 3 months ago

  • Related to action #58184: [epic][use case] full version control awareness within openQA, e.g. user forks and branches added

#8 Updated by okurz 3 months ago

  • Status changed from Blocked to Resolved
  • Target version set to Done

fetchneedles can self-repair in https://github.com/os-autoinst/openQA/pull/2486 . A better improvement is planned as part of #45302

Also available in: Atom PDF