Added by ancorgs almost 10 years ago. Updated almost 10 years ago.
100%
Description
Request and Reimbursement are not enough anymore, since the plan is to support different kind of requests, reimbursements and similar processes. Request should become TravelRequest, and so on.
Same apply to roles, with more players coming into play.
Renaming Request to TravelRequest. Still a WIP (some pending issues with inherited resources and CanCanCan).
Further analysis of the upcoming needs. Designing a slightly different approach that will allow to introduce the changes WE (in the team) need without such a big refactoring.
The current approach uses names for the models that suck but that have allowed us to move forward without needing too much refactoring:
But those convenient but counter-intuituve names should not be exposed in the interface. I18n files should be updated with proper names.
Changed the i18n to make the texts displayed to the user a little bit more intuitive. Quite some time adapting the tests.
Request will be renamed to TravelRequest. Shipment should probably be renamed to ShipmentRequest.
There will be no Request base class. The behaviour will be implemented including two concerns: HasStates and HasComments.
RequestExpense will be renamed to Expense and Reimbursement will remain as it is. Both will be reused for any kind of request that needs to go through a reimbursement process (not only TravelRequest). For sharing the Reimbursement and Expense associations there are two options:
RequestExpense renamed to Expense and first steps implementing the first alternative described in the previous comment (using concerns and polymorphic associations).
Discarding the work done before (lesson learned: don't forget to use branches) and implementing the second alternative (with a Request base class for everything since it sounds more coherent).
Working on it. Renaming and reorganizing models in Rails is always a lot of work (specially with STI involved).
rake spec:models already working after the whole refactoring/renaming (and that's 623 checks).
Now we have two abstract classes: Request and ReimbursableRequest.
Request becomes TravelSponsorship < ReimbursableRequest
Shipment becomes Shipment < Request
RequestExpense and Reimbursement are now attached to ReimbursableRequest instead of Request.
Some routes introduced for backwards compatibility. /requests and /requests/XX