action #19880
Fix power_action in console_reboot and Improve power_action
Status:
Resolved
Priority:
Normal
Assignee:
michalnowak
Category:
Bugs in existing tests
Target version:
-
Start date:
2017-06-08
Due date:
% Done:
0%
Estimated time:
Difficulty:
Description
Sorry, still not done here. E.g. see https://openqa.opensuse.org/tests/423083#step/console_reboot/10
- The test module is called "console_reboot" but the power action now assumes we want to call the reboot from X11 which is not the case here -> gh#os-autoinst/os-autoinst-distri-opensuse#3095
- Also the comment within lib/utils power_action is wrong because it describes still that we go to the root console -> gh#os-autoinst/os-autoinst-distri-opensuse#3095
- The parameter "dry-run" is really misleading because normally this is used to simulate some action for testing. This is what a "dry run" is. Not a necessary console reset - which is an action with effect in case the reboot has happened anyway
Related issues
History
#1
Updated by okurz almost 6 years ago
Updated by - Copied from action #19658: [sled][sles][functional][qam] test fails in power_action('poweroff') added
#2
Updated by okurz almost 6 years ago
IMHO the function "power_action" is trying to be too intelligent and has no clear goal. I opt for more clear lower level functions with clear names and responsibilities.
#3
Updated by okurz almost 6 years ago
- Description updated (diff)
- Status changed from New to In Progress
- Assignee changed from okurz to michalnowak
- Priority changed from High to Normal
first part done with gh#os-autoinst/os-autoinst-distri-opensuse#3095
#4
Updated by michalnowak almost 6 years ago
Updated by michalnowak - Status changed from In Progress to Feedback
#5
Updated by michalnowak almost 6 years ago
- Status changed from Feedback to Resolved
PR#3101 merged.
#6
Updated by okurz almost 6 years ago
better, thank you!