action #179699
closedsave_needles fails on osd with "no such remote or remote group: 'origin'"
Description
Observation¶
Since today 025-03-31T08:42:06.040150Z
https://openqa.suse.de/minion/jobs?id=15086321
we see save_needle tasks failing consistently.
Currently newest failure:
https://openqa.suse.de/minion/jobs?id=15087574
---
args:
- commit_message: ''
imagedir: ''
imagedistri: ''
imagename: installation-27.png
imageversion: ''
job_id: 17209378
needle_json: "{\r\n \"area\": [\r\n {\r\n \"width\": 234,\r\n \"type\":
\"match\",\r\n \"ypos\": 145,\r\n \"xpos\": 13,\r\n \"height\":
13\r\n }\r\n ],\r\n \"properties\": [],\r\n \"tags\": [\r\n \"ENV-OFW-1\",\r\n
\ \"bootloader\",\r\n \"bootloader-ofw\",\r\n \"inst-bootmenu\",\r\n \"inst-bootmenu-boot-harddisk\"\r\n
\ ]\r\n}"
needledir: /var/lib/openqa/share/tests/sle/products/sle/needles
needlename: bootloader-ofw-inst-bootmenu_on_local-boot-harddisk-20250331
overwrite: '0'
user_id: 552
...
created: 2025-03-31T11:15:48.476331Z
...
result:
error: '<strong>Failed to save bootloader-ofw-inst-bootmenu_on_local-boot-harddisk-20250331.</strong><br><pre>Unable
to fetch from origin master (/var/lib/openqa/share/tests/sle/products/sle/needles):
fatal: no such remote or remote group: ''origin''</pre>'
...
started: 2025-03-31T11:15:48.477974Z
state: failed
task: save_needle
From the openqa_gru log:
[2025-03-31T11:15:48.550794Z] [error] Git command failed: git -C /var/lib/openqa/share/tests/sle/products/sle/needles remote update 'origin' - Error: fatal: no such remote or remote group: 'origin'
When I execute this command as geekotest, it works fine.
Updated by tinita 2 months ago
I can reproduce it like this:
geekotest@openqa:~> /usr/share/openqa/script/openqa eval -m production -V 'use OpenQA::Git;
my $git = OpenQA::Git->new(dir => "/var/lib/openqa/share/tests/sle/products/sle/needles", user => 343, app => app);
say $git->config->{update_remote};
$git->set_to_latest_master;'
[INFO] Reading openqa config from: /etc/openqa/openqa.ini /etc/openqa/openqa.ini.d/openqa-salt.ini
[info] [pid:28964] Reading database config from: /etc/openqa/database.ini
[info] Loading external plugin AMQP
[info] Loading external plugin ObsRsync
'origin'
[info] [pid:28964] Running cmd: git -C /var/lib/openqa/share/tests/sle/products/sle/needles remote update 'origin'
[warn] [pid:28964] fatal: no such remote or remote group: 'origin'
[error] [pid:28964] cmd returned 1
[error] Git command failed: git -C /var/lib/openqa/share/tests/sle/products/sle/needles remote update 'origin' - Error: fatal: no such remote or remote group: 'origin'
"Unable to fetch from origin master (/var/lib/openqa/share/tests/sle/products/sle/needles): fatal: no such remote or remote group: 'origin'"
Updated by tinita 2 months ago ยท Edited
- Status changed from New to In Progress
- Assignee set to tinita
Instead this one worked:
geekotest@openqa:~> /usr/share/openqa/script/openqa eval -m production -V 'use OpenQA::Git;
my $git = OpenQA::Git->new(dir => "/var/lib/openqa/share/tests/sle/products/sle/needles", user => 343, app => app);
say $git->config->{update_remote};
use Data::Dumper;
my $res = $git->_run_cmd(["remote", "update", "origin"]);
say Dumper $res;'
[INFO] Reading openqa config from: /etc/openqa/openqa.ini /etc/openqa/openqa.ini.d/openqa-salt.ini
[info] [pid:32437] Reading database config from: /etc/openqa/database.ini
[info] Loading external plugin AMQP
[info] Loading external plugin ObsRsync
'origin'
[info] [pid:32437] Running cmd: git -C /var/lib/openqa/share/tests/sle/products/sle/needles remote update origin
[debug] [pid:32437] Fetching origin
[debug] [pid:32437]
[info] [pid:32437] cmd returned 0
$VAR1 = {
'status' => 1,
'stderr' => '',
'stdout' => 'Fetching origin
',
'return_code' => 0
};
1
And now I can see it, it's confusing because of how the command is logged:
geekotest@openqa:~> grep update_remote /etc/openqa/openqa.ini
update_remote = origin
geekotest@openqa:~> grep update_remote /etc/openqa/openqa.ini.d/openqa-salt.ini
update_remote = 'origin'
so the salt config needs to be fixed
Updated by tinita 2 months ago
- Related to action #177276: Make use of config files in openqa.ini.d for OSD specific settings size:S added
Updated by tinita 2 months ago
https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/1422 Remove singlequotes around ini values
Updated by tinita 2 months ago
- Status changed from In Progress to Feedback
https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/1422 merged, /etc/openqa/openqa.ini.d/openqa-salt.ini updated, waiting for user feedback
Updated by tinita 2 months ago
- Status changed from Feedback to Resolved
working again
https://openqa.suse.de/minion/jobs?task=save_needle