Project

General

Profile

Actions
Copy link

action #179509

open

bot-ng tries to lookup empty user-id

Added by okurz 28 days ago. Updated 28 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Regressions/Crashes
Target version:
QA (public) - Tools - Next
Start date:
2025-03-26
Due date:
% Done:

0%

Estimated time:
Tags:
infra, reactive work, bot-ng

Description

Observation

From
https://gitlab.suse.de/qa-maintenance/bot-ng/-/jobs/4042675#L105

+++ curl -s --fail-with-body --request GET --header 'PRIVATE-TOKEN: [MASKED]' 'https://gitlab.suse.de/api/v4/users?username=jbaier'
+++ jq -r '.[].id?'
++ uid=
++ curl -s --fail-with-body --request GET --header 'PRIVATE-TOKEN: [MASKED]' https://gitlab.suse.de/api/v4/users//gpg_keys

IMHO we should not continue trying to look-up an empty uid but not fail the pipeline as we must not expect all "suse" looking commits to have an according user on gitlab.

Related issues 1 (0 open — 1 closed)

Copied from openQA Infrastructure (public) - action #179503: »bot-ng | Failed pipeline for master« due to gpg issuesResolvedokurz

Actions
Actions
Copy link
 #1

Updated by okurz 28 days ago

  • Copied from action #179503: »bot-ng | Failed pipeline for master« due to gpg issues added
Actions
Copy link
 #2

Updated by okurz 28 days ago

  • Parent task set to #166592
Actions
Copy link
 #3

Updated by tinita 28 days ago

But the problem needs to be fixed even on a higher level.
For example Jan's email address in the commit is jbaier@suse.cz but his username on gitlab is jbaier_cz.
I guess I will have the same problem (timueller vs. tinita).
Should we just use a fake email address for our commits to make that logic work?

Actions
Copy link
 #4

Updated by tinita 28 days ago

Why are we even trying to get keys from gitlab when this is about github commits? We can just retrieve the public keys from github.
e.g. https://github.com/$user.gpg and https://github.com/$user.keys

Actions
Copy link
 #5

Updated by livdywan 28 days ago

tinita wrote in #note-4:

Why are we even trying to get keys from gitlab when this is about github commits? We can just retrieve the public keys from github.
e.g. https://github.com/$user.gpg and https://github.com/$user.keys

Remember we don't trust GitHub

Actions
Copy link

Also available in: Atom PDF