Project

General

Profile

Actions
Copy link

action #170206

closed

CircleCI failing: t/24-worker-engine.t: Use of uninitialized value $string size:S

Added by tinita 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
High
Assignee:
tinita
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2024-11-25
Due date:
% Done:

0%

Estimated time:

Description

Observation

A test started to fail a few days ago, it seems to be consistent:

https://app.circleci.com/pipelines/github/os-autoinst/openQA/15269/workflows/2eb1719f-c2e8-4c0f-b3f0-aff3228f2209/jobs/146122

[09:52:39] t/24-worker-engine.t ...................................... 1/? 
#   Failed test 'no (unexpected) warnings (via done_testing)'
#   at t/24-worker-engine.t line 549.
# Got the following unexpected warnings:
#   1: Use of uninitialized value $string in substitution (s///) at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/IOLoop/ReadWriteProcess/CGroup.pm line 26.
#   2: Use of uninitialized value $string in substr at /usr/lib/perl5/vendor_perl/5.26.1/Mojo/IOLoop/ReadWriteProcess/CGroup.pm line 28.
# Looks like you failed 1 test of 13.
[09:52:39] t/24-worker-engine.t ...................................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/13 subtests

Acceptance Criteria

  • AC1: t/24-worker-engine.t consistently passes

Suggestions

  • The failure seems to be 100% reproducible in all PR's
  • Verify if e.g. dependency updates affect this case
    • Bisect openQA in case there was a change that caused a regression
    • Check Mojo/IOLoop/ReadWriteProcess upstream
Actions
Copy link
 #1

Updated by livdywan 3 months ago

  • Subject changed from CircleCI failing: t/24-worker-engine.t: Use of uninitialized value $string to CircleCI failing: t/24-worker-engine.t: Use of uninitialized value $string size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link
 #2

Updated by livdywan 3 months ago

  • Status changed from Workable to In Progress
  • Assignee set to livdywan

I'm taking a look. Given the issue is reproducible with a Tumbelweed container from 2024-06 I'm assuming this is not a recent dependency change. Trying older revisions of openQA git now.

Actions
Copy link
 #3

Updated by livdywan 3 months ago

livdywan wrote in #note-2:

I'm taking a look. Given the issue is reproducible with a Tumbelweed container from 2024-06 I'm assuming this is not a recent dependency change. Trying older revisions of openQA git now.

Relevant code: lib/Mojo/IOLoop/ReadWriteProcess/CGroup.pm#L26

Actions
Copy link
 #4

Updated by livdywan 3 months ago · Edited

livdywan wrote in #note-3:

Relevant code: lib/Mojo/IOLoop/ReadWriteProcess/CGroup.pm#L26

More specifically _configure_cgroupv2 ends up with an undefined $cgroup_slice aka $string. In my container the file seems to contain 0::/ with no name= in it. I wonder how this was not an issue before? 🤔

Actions
Copy link
 #5

Updated by livdywan 3 months ago · Edited

  • Status changed from In Progress to Workable
  • Assignee deleted (livdywan)

I tried to adapt the code to avoid ending up with a $cgroup_slice which is not initialized but somehow couldn't find a way to check that grep contains a string.
Maybe there is something else that I'm missing? Putting it back in the queue for now.

Actions
Copy link
 #6

Updated by tinita 3 months ago

  • Status changed from Workable to In Progress
  • Assignee set to tinita
Actions
Copy link
 #7

Updated by tinita 3 months ago

  • Status changed from In Progress to Feedback

https://github.com/os-autoinst/openQA/pull/6067 Avoid warning for undefined cgroup slice

Actions
Copy link
 #8

Updated by tinita 3 months ago

  • Status changed from Feedback to Resolved

merged, CircleCI pipelines passing again

Actions
Copy link

Also available in: Atom PDF